airavata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aarushi Bisht (Jira)" <j...@apache.org>
Subject [jira] [Commented] (AIRAVATA-2873) getExperiment should throw ExperimentNotFoundException when experiment not found
Date Tue, 04 Feb 2020 00:43:00 GMT

    [ https://issues.apache.org/jira/browse/AIRAVATA-2873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17029400#comment-17029400
] 

Aarushi Bisht commented on AIRAVATA-2873:
-----------------------------------------

In the RegistryServerHandler.java methods throw ExperimentNotFoundException when an experiment
Id is not found.

In AiravataServerHandler.java this exception is caught and thrown as AiravataSystemException.
Refactor the appropriate methods in AiravataServerHandler to also throw ExperimentNotFoundException.

> getExperiment should throw ExperimentNotFoundException when experiment not found
> --------------------------------------------------------------------------------
>
>                 Key: AIRAVATA-2873
>                 URL: https://issues.apache.org/jira/browse/AIRAVATA-2873
>             Project: Airavata
>          Issue Type: Bug
>          Components: Airavata API
>            Reporter: Marcus Christie
>            Priority: Major
>
> Currently getExperiment catches the registry's ExperimentNotFoundException and rethrows
it as an AiravataSystemException.  Clients like the PGA expect that an ExperimentNotFoundException
would be thrown if the experiment with that id doesn't exist.
> This affects other methods too:
> * deleteExperiment
> * getExperimentByAdmin
> * updateExperiment
> By contract, launchExperiment does handle it correctly by rethrowing the ExperimentNotFoundException.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message