From issues-return-17116-archive-asf-public=cust-asf.ponee.io@airavata.apache.org Fri Jan 10 20:02:02 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 15965180657 for ; Fri, 10 Jan 2020 21:02:01 +0100 (CET) Received: (qmail 42131 invoked by uid 500); 10 Jan 2020 20:02:01 -0000 Mailing-List: contact issues-help@airavata.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@airavata.apache.org Received: (qmail 42122 invoked by uid 99); 10 Jan 2020 20:02:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 10 Jan 2020 20:02:01 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id AC06EE29D3 for ; Fri, 10 Jan 2020 20:02:00 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id 2BEF77805EA for ; Fri, 10 Jan 2020 20:02:00 +0000 (UTC) Date: Fri, 10 Jan 2020 20:02:00 +0000 (UTC) From: "ASF subversion and git services (Jira)" To: issues@airavata.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (AIRAVATA-3276) BUG: non uploaded files argument appears in command-line in job script MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/AIRAVATA-3276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17013170#comment-17013170 ] ASF subversion and git services commented on AIRAVATA-3276: ----------------------------------------------------------- Commit 2eea2170cb49fe4cec820c56421b91a3eb9e6023 in airavata's branch refs/heads/develop from Marcus Christie [ https://gitbox.apache.org/repos/asf?p=airavata.git;h=2eea217 ] AIRAVATA-3276 Migration script for ui config change > BUG: non uploaded files argument appears in command-line in job script > ---------------------------------------------------------------------- > > Key: AIRAVATA-3276 > URL: https://issues.apache.org/jira/browse/AIRAVATA-3276 > Project: Airavata > Issue Type: Sub-task > Components: Django Portal > Affects Versions: 0.18 > Environment: https://seagrid.org/ > Reporter: Eroma > Assignee: Marcus Christie > Priority: Major > Fix For: 0.19 > > > 1. Created new application ABAQUS-6.14-1 > 2. In this application a file need to be uploaded as optional file. > 3. This particular input also has an argument. > 4. When the file is not uploaded the argument appears in command-line without the file. > 5. The argument should only appear with the filename when the file is uploaded. > h3. TODO > - (/) Update backend to ignore inputs with requiredToAddedToCommandLine=true when value is null or empty and isRequired=false > - (/) Automatically add "showOptions" configuration for toggling isRequired > - (/) Change "showOptions" metadata to {noformat}{"showOptions": {"isRequired": true}}{noformat} with data migration > -- need backwards compatibility with old schema in code > h3. Production rollout > - deploy backend changes - https://github.com/apache/airavata/tree/airavata-3276 > - deploy frontend changes - https://github.com/apache/airavata-django-portal/tree/AIRAVATA-3276--BUG--non-uploaded-files-argument-appears-in-command-line-in-job-script > - run data migration script for frontend changes > h3. Summary > With these changes in place, admins no longer need to add special configuration for dependent inputs that have isRequired=true or requiredToAddedToCommandLine=true. The application interface editor will automatically add {noformat} > {"showOptions": {"isRequired": true}} > {noformat} > to the JSON configuration for a dependent input. -- This message was sent by Atlassian Jira (v8.3.4#803005)