airavata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AIRAVATA-2644) Bubble up validation state
Date Wed, 17 Apr 2019 19:54:00 GMT

    [ https://issues.apache.org/jira/browse/AIRAVATA-2644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16820451#comment-16820451
] 

ASF subversion and git services commented on AIRAVATA-2644:
-----------------------------------------------------------

Commit c8e9c98b0b375b2ea39b8aee32a48deba6a96e0e in airavata-django-portal's branch refs/heads/master
from Marcus Christie
[ https://gitbox.apache.org/repos/asf?p=airavata-django-portal.git;h=c8e9c98 ]

AIRAVATA-2644 Use events to communicate invalid state from child to parent


> Bubble up validation state
> --------------------------
>
>                 Key: AIRAVATA-2644
>                 URL: https://issues.apache.org/jira/browse/AIRAVATA-2644
>             Project: Airavata
>          Issue Type: Sub-task
>            Reporter: Marcus Christie
>            Assignee: Marcus Christie
>            Priority: Major
>
> Some UI components have access to data that allows richer validation than can be performed
purely at the model layer. Invalid components should be able to dispatch an event that parent
components take into account when decided overall form validation state.
> In particular, QueueSettingsEditor knows how to validate max queue values (like max nodes),
but Experiment.validate() doesn't have access to the queue information to be able to run this
kind of validation.  If the QueueSettingsEditor is invalid it should dispatch an event that
the ComputationalResourceSchedulingEditor listens for and likewise dispatches an invalid event
that the ExperimentEditor will get and use to determine that the overall form validation state
is also invalid.
> In general, Model.validate() should only be used to validate the local values on that
model instance instead of recursively calling validate() on child models. Aggregating validation
state should be handled at the UI component level.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message