From issues-return-15155-archive-asf-public=cust-asf.ponee.io@airavata.apache.org Tue Feb 5 15:39:04 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id DEF43180608 for ; Tue, 5 Feb 2019 16:39:03 +0100 (CET) Received: (qmail 12539 invoked by uid 500); 5 Feb 2019 15:39:03 -0000 Mailing-List: contact issues-help@airavata.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@airavata.apache.org Received: (qmail 12528 invoked by uid 99); 5 Feb 2019 15:39:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Feb 2019 15:39:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 9D8C9C2777 for ; Tue, 5 Feb 2019 15:39:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id tiz269IieT2V for ; Tue, 5 Feb 2019 15:39:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 3F3535F178 for ; Tue, 5 Feb 2019 15:39:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id C77FFE26EC for ; Tue, 5 Feb 2019 15:39:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 8A06C24417 for ; Tue, 5 Feb 2019 15:39:00 +0000 (UTC) Date: Tue, 5 Feb 2019 15:39:00 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: issues@airavata.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (AIRAVATA-2938) Change DB initialization in Registry server to use registry-refactoring code MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/AIRAVATA-2938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16760942#comment-16760942 ] ASF subversion and git services commented on AIRAVATA-2938: ----------------------------------------------------------- Commit 156b7c59562b4623a60db24a403856ad6841b9a0 in airavata's branch refs/heads/develop from Marcus Christie [ https://gitbox.apache.org/repos/asf?p=airavata.git;h=156b7c5 ] AIRAVATA-2938 Migration to bring DB into sync with DB init script > Change DB initialization in Registry server to use registry-refactoring code > ---------------------------------------------------------------------------- > > Key: AIRAVATA-2938 > URL: https://issues.apache.org/jira/browse/AIRAVATA-2938 > Project: Airavata > Issue Type: Bug > Reporter: Marcus Christie > Assignee: Marcus Christie > Priority: Major > Attachments: app_catalog_diff.sql, credential_store_diff.sql, profile_service_diff.sql, replica_catalog_diff.sql, sharing_catalog_diff.sql > > > TODO > * [x] Move DB intialization code to airavata-commons. Code in registry-core is duplicated in airavata-sharing-registry-server and airavata-credential-store. > ** Don't need a connection pool (JdbcStorage) for initializing a database > ** Single DBInitializer class that takes a config object with JDBC properties etc. > ** Each database has its own initialization class that can also have a postInit method to do any database setup > * [x] Update distribution bin assembly to include db scripts from registry-refactoring > * [x] Update RegistryAPIServer to call DBInitializers from registry-refactoring > * [x] code cleanup: DatabaseCreator copies > ** (/) CredentialStoreInitUtil > ** (/) orchestrator-core Initialize > ** (/) registry-refactoring: expcatalog Initialize.java > ** (/) registry-refactoring: replicacatalog Initialize.java > ** (/) registry-refactoring: workflowcatalog Initialize.java > ** -registry-core: appcatalog Initailize.java- registry-core is deprecated so no need to convert these > ** -registry-core: expcatalog Initialize.java- > ** -registry-core: replicacatalog Initialize.java- > ** (/) registry-server: appcatalog AppCatalogInitUtil > ** (/) registry-server: DatabaseCreator > ** (/) registry-server: ExpCatalogInitUtil > ** (/) registry-server: ReplicaCatalogInitUtil > ** (/) registry-server: WorkflowCatalogInitUtil > ** (/) sharing-registry-server: JPAUtils > ** (/) sharing-registry-server: Initialize > ** -registry-tool: DBMigrator- not going to touch this now > ** (/) gfac-service: Initialize > * [x] code cleanup: DBInitializer copies > ** (/) profile-service-commons: Utils.java > ** (/) CredentialStoreInitiUtil > ** -registry-core: Utils- registry-core is deprecated so no need to convert > * [x] code cleanup: DerbyUtils.java copies > ** AiravataDerbyServer > ** other locations listed in above lists > * [x] code cleanup: Merge DerbyUtils.java and DerbyDBManager.java > * [x] run a DB schema diff between a clean database initialized by these refactored scripts and a live existing Airavata develop database (dbdev.scigap.org) > * [x] move Derby start code out of DBInitializer? > * [x] Factor out EntityManagerFactory creation code from AppCatalogJPAUtils and use for all databases > * [x] turn off the feature in OpenJPA where it adds missing columns/tables automatically. Instead we'll require DB scripts, migration scripts. > * [ ] rerun DB schema diff after running migration scripts on live develop database -- This message was sent by Atlassian JIRA (v7.6.3#76005)