From issues-return-13800-archive-asf-public=cust-asf.ponee.io@airavata.apache.org Mon Apr 30 21:38:08 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 0CDC7180677 for ; Mon, 30 Apr 2018 21:38:07 +0200 (CEST) Received: (qmail 28395 invoked by uid 500); 30 Apr 2018 19:38:07 -0000 Mailing-List: contact issues-help@airavata.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@airavata.apache.org Received: (qmail 28385 invoked by uid 99); 30 Apr 2018 19:38:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 30 Apr 2018 19:38:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 78E3AC0558 for ; Mon, 30 Apr 2018 19:38:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id YAWRwvO1TdsX for ; Mon, 30 Apr 2018 19:38:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id F10265FC04 for ; Mon, 30 Apr 2018 19:38:03 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 9BC9CE12B0 for ; Mon, 30 Apr 2018 19:38:02 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 746F52149F for ; Mon, 30 Apr 2018 19:38:01 +0000 (UTC) Date: Mon, 30 Apr 2018 19:38:01 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@airavata.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (AIRAVATA-2728) Refactoring Experiment Catalog Implementation MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/AIRAVATA-2728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16458940#comment-16458940 ] ASF GitHub Bot commented on AIRAVATA-2728: ------------------------------------------ machristie commented on a change in pull request #191: [AIRAVATA-2728] Refactoring Experiment Catalog Implementation URL: https://github.com/apache/airavata/pull/191#discussion_r185084422 ########## File path: modules/registry-refactoring/src/main/java/org/apache/airavata/registry/core/repositories/expcatalog/JobRepository.java ########## @@ -0,0 +1,181 @@ +package org.apache.airavata.registry.core.repositories.expcatalog; + +import org.apache.airavata.model.job.JobModel; +import org.apache.airavata.model.status.JobStatus; +import org.apache.airavata.model.task.TaskModel; +import org.apache.airavata.registry.core.entities.expcatalog.JobEntity; +import org.apache.airavata.registry.core.entities.expcatalog.JobStatusEntity; +import org.apache.airavata.registry.core.utils.DBConstants; +import org.apache.airavata.registry.core.utils.ExpCatalogUtils; +import org.apache.airavata.registry.core.utils.ObjectMapperSingleton; +import org.apache.airavata.registry.core.utils.QueryConstants; +import org.apache.airavata.registry.cpi.CompositeIdentifier; +import org.apache.airavata.registry.cpi.RegistryException; +import org.dozer.Mapper; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.sql.Timestamp; +import java.util.ArrayList; +import java.util.HashMap; +import java.util.List; +import java.util.Map; + +public class JobRepository extends ExpCatAbstractRepository { + private final static Logger logger = LoggerFactory.getLogger(JobRepository.class); + + public JobRepository() { super(JobModel.class, JobEntity.class); } + + protected String saveJobModelData(JobModel jobModel, CompositeIdentifier cis) throws RegistryException { + JobEntity jobEntity = saveJob(jobModel, cis); + return jobEntity.getJobId(); + } + + protected JobEntity saveJob(JobModel jobModel, CompositeIdentifier cis) throws RegistryException { + if (jobModel.getJobId() == null || jobModel.getJobId().equals("DO_NOT_SET_AT_CLIENTS")) { Review comment: Use a constant for DO_NOT_SET_AT_CLIENTS, see above. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org > Refactoring Experiment Catalog Implementation > --------------------------------------------- > > Key: AIRAVATA-2728 > URL: https://issues.apache.org/jira/browse/AIRAVATA-2728 > Project: Airavata > Issue Type: Improvement > Components: Registry API > Reporter: Sneha Tilak > Assignee: Sneha Tilak > Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)