Mailing-List: contact dev-help@airavata.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@airavata.apache.org
Received-SPF: pass (nike.apache.org: domain of samindaw@gmail.com designates
 209.85.215.41 as permitted sender)
MIME-Version: 1.0
In-Reply-To: 
 <CAKq9_6LYdp_v3ZVyxWFCotZMpsPnsDNxEW0fYqT6MG=SDf33CQ@mail.gmail.com>
References: 
 <CAKq9_6LYdp_v3ZVyxWFCotZMpsPnsDNxEW0fYqT6MG=SDf33CQ@mail.gmail.com>
From: Saminda Wijeratne <samindaw@gmail.com>
Date: Tue, 5 Aug 2014 14:59:04 -0400
Message-ID: 
 <CANotcz5sMZVnSSw2oin8q_goW2SCNu09ukFmzB7__zpb=GA_eg@mail.gmail.com>
Subject: Re: How to add a new Jobsubmission
To: dev <dev@airavata.apache.org>
Content-Type: multipart/alternative; boundary=001a11c3ac003eb45a04ffe67469

--001a11c3ac003eb45a04ffe67469
Content-Type: text/plain; charset=UTF-8

Hi Lahiru,

I understand your pain. You guessed it correct. All these inconveniences
are due to limitations in thrift where it doesn't support inheritance and
polymorphism. We'd be glad for a better approach which thrift would also
support. :)


On Tue, Aug 5, 2014 at 12:32 AM, Lahiru Gunathilake <glahiru@gmail.com>
wrote:

> Hi All,
>
> Please bear with me for my less knowledge about thrift, I have following
> questions about thrift models  in app-catalog when I tried to add a new
> jobSubmission to computeResourceModel.
>
> We have few JobSubmissionProtocols and I wanted to add a new protocol. I
> am not sure why we have defined each struct separate, why can't we have
> inheritance(my guess is thrift doesn't support).
>
> When I added the new type I realized I have to add a new method in
> Airavata.java to store that new type. Each Job Submission protocol has to
> be saved first and have to implement a new method to add  that. For me this
> seems little odd. We have methods
> like addSSHJobSubmissionDetails, addLocalSubmissionDetails. This is a very
> big change because I have to again add a new method to Airavata thrift
> service and add an implementation to AiravataServerHandler. When I look in
> to these objects they cannot be re-used among compute resources because
> they have very much machine specific details like(ssh port etc), so a
> single SSHJobSubmission object shouldn't be shared among different hosts,
> in that case why do we have to save them separate and get an ID and set
> that ID to computing resource.
>
> And there is another class ComputeResourceImpl and it has the same set of
> methods to add each and every object then I have to add another method to
> that and invoke that in the AiravataServerHandler.java. Can someone please
> tell me why do we have to invoke registry 4 times to save a
> computingResource, why can't I just set everything to the computing
> Resource and save with a single operation ? What are the reasons we have
> operations to save each atomic things in computingResources and give
> computingResourceId for each component.
>
> For all these questions, the only answer is that thrift doesn't support
> inheritance,then I do understand... otherwise we can improve it. As a CPI
> user I feels this is too complex and very difficult to develop and modify a
> single thing in CPI I have to change so many places.
>
> Regards
> Lahiru
> --
> System Analyst Programmer
> PTI Lab
> Indiana University
>

--001a11c3ac003eb45a04ffe67469
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi Lahiru,<br><br>I understand your pain. You guessed it c=
orrect. All these inconveniences are due to limitations in thrift where it =
doesn&#39;t support inheritance and polymorphism. We&#39;d be glad for a be=
tter approach which thrift would also support. :)<br>

</div><div class=3D"gmail_extra"><br><br><div class=3D"gmail_quote">On Tue,=
 Aug 5, 2014 at 12:32 AM, Lahiru Gunathilake <span dir=3D"ltr">&lt;<a href=
=3D"mailto:glahiru@gmail.com" target=3D"_blank">glahiru@gmail.com</a>&gt;</=
span> wrote:<br>

<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex"><div dir=3D"ltr">Hi All,<div><br></div><div>=
Please bear with me for my less knowledge about thrift, I have following qu=
estions about thrift models =C2=A0in app-catalog when I tried to add a new =
jobSubmission to computeResourceModel.</div>


<div><br></div><div>We have few JobSubmissionProtocols and I wanted to add =
a new protocol. I am not sure why we have defined each struct separate, why=
 can&#39;t we have inheritance(my guess is thrift doesn&#39;t support).</di=
v>


<div><br></div><div>When I added the new type I realized I have to add a ne=
w method in Airavata.java to store that new type. Each Job Submission proto=
col has to be saved first and have to implement a new method to add =C2=A0t=
hat. For me this seems little odd. We have methods like=C2=A0addSSHJobSubmi=
ssionDetails,=C2=A0addLocalSubmissionDetails. This is a very big change bec=
ause I have to again add a new method to Airavata thrift service and add an=
 implementation to AiravataServerHandler. When I look in to these objects t=
hey cannot be re-used among compute resources because they have very much m=
achine specific details like(ssh port etc), so a single SSHJobSubmission ob=
ject shouldn&#39;t be shared among different hosts, in that case why do we =
have to save them separate and get an ID and set that ID to computing resou=
rce.</div>


<div><br></div><div>And there is another class ComputeResourceImpl and it h=
as the same set of methods to add each and every object then I have to add =
another method to that and invoke that in the AiravataServerHandler.java. C=
an someone please tell me why do we have to invoke registry 4 times to save=
 a computingResource, why can&#39;t I just set everything to the computing =
Resource and save with a single operation ? What are the reasons we have op=
erations to save each atomic things in computingResources and give computin=
gResourceId for each component.</div>


<div><br></div><div>For all these questions, the only answer is that thrift=
 doesn&#39;t support inheritance,then I do understand... otherwise we can i=
mprove it. As a CPI user I feels this is too complex and very difficult to =
develop and modify a single thing in CPI I have to change so many places.</=
div>


<div><br></div><div>Regards</div><span class=3D"HOEnZb"><font color=3D"#888=
888"><div>Lahiru</div><div>-- <br>System Analyst Programmer<div>PTI Lab</di=
v><div>Indiana University</div>
</div></font></span></div>
</blockquote></div><br></div>

--001a11c3ac003eb45a04ffe67469--