Mailing-List: contact dev-help@airavata.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@airavata.apache.org
Received-SPF: pass (athena.apache.org: domain of glahiru@gmail.com designates
 209.85.212.169 as permitted sender)
MIME-Version: 1.0
Date: Sun, 18 May 2014 09:57:11 -0400
Message-ID: 
 <CAKq9_6JLaHf_YLD9iPgGu-X4UEhcULDEPW+nhggJqqq5oqHBtg@mail.gmail.com>
Subject: Thrift service operation exception handling
From: Lahiru Gunathilake <glahiru@gmail.com>
To: dev <dev@airavata.apache.org>
Content-Type: multipart/alternative; boundary=047d7bdcab7cf3051c04f9ad056f

--047d7bdcab7cf3051c04f9ad056f
Content-Type: text/plain; charset=UTF-8

Hi all,

When I went through the exception handling in thrift services I see we have
bunch of exception types defined in thrift and non of them are really
thrown in any of the service operations.
    All these exceptions are stored in airavata-api-stubs module and
airavata-api-server is having a dependency to airavata-api-stubs. Having a
dependency to stub from the service is little awkward to me in web services
point but I am not sure about thrift. If this is wrong I think we have to
move this common code to some other place.

Issue comes when I try to implement orchestrator validateExperiment
operation where I have to throw an experiment defined in airavata-api-stubs
and it was little awkward to have a dependency to airavata-api-stubs from
orchestrator-server and orchestrator-client. Same exception has to be
thrown by the airavata-server's launchExperiment method. I think these
exception classes and common code can go to data-models module which is
shared across both the orchestrator and airavata-server thrift services.

Please correct me if I am wrong.

Lahiru

-- 
System Analyst Programmer
PTI Lab
Indiana University

--047d7bdcab7cf3051c04f9ad056f
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi all,<div><br></div><div>When I went through the excepti=
on handling in thrift services I see we have bunch of exception types defin=
ed in thrift and non of them are really thrown in any of the service operat=
ions.</div>
<div>=C2=A0 =C2=A0 All these exceptions are stored in airavata-api-stubs mo=
dule and airavata-api-server is having a dependency to airavata-api-stubs. =
Having a dependency to stub from the service is little awkward to me in web=
 services point but I am not sure about thrift. If this is wrong I think we=
 have to move this common code to some other place.</div>
<div><br></div><div>Issue comes when I try to implement orchestrator valida=
teExperiment operation where I have to throw an experiment defined in airav=
ata-api-stubs and it was little awkward to have a dependency to airavata-ap=
i-stubs from orchestrator-server and orchestrator-client. Same exception ha=
s to be thrown by the airavata-server&#39;s launchExperiment method. I thin=
k these exception classes and common code can go to data-models module whic=
h is shared across both the orchestrator and airavata-server thrift service=
s.</div>
<div><br></div><div>Please correct me if I am wrong.</div><div><br></div><d=
iv>Lahiru<br clear=3D"all"><div><br></div>-- <br>System Analyst Programmer<=
div>PTI Lab</div><div>Indiana University</div>
</div></div>

--047d7bdcab7cf3051c04f9ad056f--