Mailing-List: contact dev-help@airavata.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@airavata.apache.org
Received-SPF: pass (nike.apache.org: domain of thejaka.amila@gmail.com
 designates 209.85.219.50 as permitted sender)
MIME-Version: 1.0
In-Reply-To: 
 <CANotcz7utanGhFS2RiPuhqXTwTHGa9eO1JqwRHCnpP4OUcAVhQ@mail.gmail.com>
References: 
 <CAKUcLKZy0SOAgcYUA5MVY3c-Zygs5dBj6XZCP+OC2cGi4DhTkg@mail.gmail.com>
	<CAKq9_6K0xH=pVtEt_XQfSPUARdJJF4fab0+sQEt9522c1yLCRw@mail.gmail.com>
	<CANotcz5hL1F38j0_x7P8-mCRRN3DnN_-kWMkgjtMOvij80yQTA@mail.gmail.com>
	<49E55B39-CC7A-4A55-9FA1-15CE00619C47@apache.org>
	<CAKUcLKaMj26kSWvpeG3Ef_owL57EFvbKUgVQ5mnjMvHoBbU_pw@mail.gmail.com>
	<CANotcz4wu-9Rcy=+Bq2SbYpUxvBPaK_hBi0G07NbEYQhK4udnw@mail.gmail.com>
	<CAKUcLKawe+fp3YxJ1BFDJsioiHiTo9im+GiKVgj-K23gZQYT=Q@mail.gmail.com>
	<CANotcz7utanGhFS2RiPuhqXTwTHGa9eO1JqwRHCnpP4OUcAVhQ@mail.gmail.com>
Date: Tue, 2 Jul 2013 20:56:38 -0400
Message-ID: 
 <CAKUcLKbkQE=FUzVPsihJCnBTPcYouPL=m+ZfeSbVtkvFXmp0uA@mail.gmail.com>
Subject: Re: Question about null check in GFacUtils
From: Amila Jayasekara <thejaka.amila@gmail.com>
To: dev@airavata.apache.org
Content-Type: multipart/alternative; boundary=047d7bd7672023bf9304e090ef24

--047d7bd7672023bf9304e090ef24
Content-Type: text/plain; charset=ISO-8859-1

Hi Saminda,


On Tue, Jul 2, 2013 at 7:14 PM, Saminda Wijeratne <samindaw@gmail.com>wrote:

> is it the name you are confused with or the function of it?
>
> The waitFor function runs until the job is completed or failed.


Correct. But actual status of the job is report to statusChange method.
statusChange method calls "setStatus" method. The setStatus method has a
call to "GFacUtils.updateApplicationJobStatus(context,job.getIDAsString(),
                GFacUtils.getApplicationJobStatus(status));"

So whether job is finished or failed is already recorded through the
setStatus method. I guess we dont need to record it again in waitFor method.

Thanks
Amila


> The way it
> knows that the job is completed is by checking the gram status of the job
> periodically via a while loop.
>
> On Tue, Jul 2, 2013 at 6:34 PM, Amila Jayasekara <thejaka.amila@gmail.com
> >wrote:
>
> > The "updateApplicationJobStatusUpdateTime" method is called from
> > GramJobSubmissionListener.waitFor method. I dont understand why that
> method
> > is called from waitFor method.
> >
> > Could you please explain ?
> >
> > Thanks
> > Amila
> >
> >
> > On Tue, Jul 2, 2013 at 5:26 PM, Saminda Wijeratne <samindaw@gmail.com
> > >wrote:
> >
> > > Hi Amila,
> > >
> > > These are my additions. Basically we are recording the status of the
> > > application execution with the time which it was observed. However
> > > sometimes the same status is observed continuously by the
> > > observers/listeners defined in the provider for that job. In those
> times
> > we
> > > update only the time which that same status was observed last.
> > >
> > > If you think that the name of the function is confusing shall we change
> > it?
> > > These are util functions which the providers may or may not use for
> their
> > > convenience.
> > >
> > > Saminda
> > >
> > >
> > > On Tue, Jul 2, 2013 at 4:57 PM, Amila Jayasekara <
> > thejaka.amila@gmail.com
> > > >wrote:
> > >
> > > > Hi Lahiru,
> > > >
> > > > I have few more questions related to this.
> > > > In GFacUtils class I see following 2 methods;
> > > >
> > > >     public static void
> > > > updateApplicationJobStatusUpdateTime(JobExecutionContext context,
> > String
> > > > jobId, Date statusUpdateTime)
> > > >     public static void updateApplicationJobStatus(JobExecutionContext
> > > > context, String jobId, ApplicationJobStatus status, Date
> > > statusUpdateTime)
> > > >
> > > > What is the difference between about 2 methods ? More precisely I am
> > > having
> > > > difficulty understanding the need for 1st method.
> > > >
> > > > Thanks
> > > > Amila
> > > >
> > > >
> > > >
> > > > On Tue, Jul 2, 2013 at 3:13 PM, Suresh Marru <smarru@apache.org>
> > wrote:
> > > >
> > > > > On Jul 2, 2013, at 2:19 PM, Saminda Wijeratne <samindaw@gmail.com>
> > > > wrote:
> > > > >
> > > > > > Are we not going to allow using the GFac libraries as standalone
> > > tool?
> > > > It
> > > > > > could be useful for devs who dont want to use the workflow
> context
> > to
> > > > run
> > > > > > applications.
> > > > >
> > > > > I would vote against direct use of GFac API from clients. We need
> to
> > > > > brainstorm and decide on the component level API's and their
> > > implications
> > > > > once we discuss Airavata 1.0( may be also 2.0) roadmaps.
> > > > >
> > > > > In short, I see the need for GFac API's to evolve to facilitate
> more
> > > > > dynamism and multi-phased interactions between workflow interpreter
> > and
> > > > > GFac. I think we should limit all client integrations to Airavata
> API
> > > so
> > > > we
> > > > > can put in extra effort to ensure backward compatibility is
> > maintained
> > > > > within major versions.
> > > > >
> > > > > Suresh
> > > > >
> > > > > > On Tue, Jul 2, 2013 at 9:53 AM, Lahiru Gunathilake <
> > > glahiru@gmail.com
> > > > > >wrote:
> > > > > >
> > > > > >> It's not required now. Please remove it.
> > > > > >>
> > > > > >>
> > > > > >> Lahiru
> > > > > >>
> > > > > >> On Tuesday, July 2, 2013, Amila Jayasekara wrote:
> > > > > >>
> > > > > >>> Hi All,
> > > > > >>>
> > > > > >>> In GFacUtils I see methods like follows;
> > > > > >>>
> > > > > >>> public static void
> > > > > >> updateApplicationJobStatusUpdateTime(JobExecutionContext
> > > > > >>> context, String jobId, Date statusUpdateTime){
> > > > > >>>        AiravataAPI airavataAPI =
> > > > > >>> context.getGFacConfiguration().getAiravataAPI();
> > > > > >>> if(airavataAPI != null){
> > > > > >>> try {
> > > > > >>>
> > > > > >>>
> > > > > >>
> > > > >
> > > >
> > >
> >
> airavataAPI.getProvenanceManager().updateApplicationJobStatusUpdateTime(jobId,
> > > > > >>> statusUpdateTime);
> > > > > >>> } catch (AiravataAPIInvocationException e) {
> > > > > >>> log.error("Error in updating application job status time
> > > > > >>> "+statusUpdateTime.toString()+" for job Id "+jobId+"!!!", e);
> > > > > >>> }
> > > > > >>>        }
> > > > > >>> }
> > > > > >>>
> > > > > >>> Any particular reason to have "if(airavataAPI != null)"
> > condition ?
> > > > > >>>
> > > > > >>> Thanks
> > > > > >>> Amila
> > > > > >>>
> > > > > >>
> > > > > >>
> > > > > >> --
> > > > > >> System Analyst Programmer
> > > > > >> PTI Lab
> > > > > >> Indiana University
> > > > > >>
> > > > >
> > > > >
> > > >
> > >
> >
>

--047d7bd7672023bf9304e090ef24--