Return-Path: X-Original-To: apmail-airavata-dev-archive@www.apache.org Delivered-To: apmail-airavata-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D0CF49F10 for ; Fri, 7 Dec 2012 19:43:54 +0000 (UTC) Received: (qmail 84204 invoked by uid 500); 7 Dec 2012 19:43:54 -0000 Delivered-To: apmail-airavata-dev-archive@airavata.apache.org Received: (qmail 84173 invoked by uid 500); 7 Dec 2012 19:43:54 -0000 Mailing-List: contact dev-help@airavata.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@airavata.apache.org Delivered-To: mailing list dev@airavata.apache.org Received: (qmail 84164 invoked by uid 99); 7 Dec 2012 19:43:54 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Dec 2012 19:43:54 +0000 X-ASF-Spam-Status: No, hits=-1.6 required=5.0 tests=RCVD_IN_DNSWL_MED,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Received: from [129.79.247.4] (HELO newman.cs.indiana.edu) (129.79.247.4) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Dec 2012 19:43:45 +0000 Received: from smtp.cs.indiana.edu (smtp.cs.indiana.edu [129.79.247.7]) by newman.cs.indiana.edu (8.13.8/8.13.8/IUCS_2.97) with ESMTP id qB7JhNKo024091 for ; Fri, 7 Dec 2012 14:43:23 -0500 Received: from 156-56-194-148.ssl-vpn.indiana.edu (156-56-194-148.ssl-vpn.indiana.edu [156.56.194.148]) (authenticated bits=0) by rage.cs.indiana.edu (8.13.1/8.13.1/IUCS_SMTP_Alternate_Port_1.5) with ESMTP id qB7JhLe6022711 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Fri, 7 Dec 2012 14:43:23 -0500 Message-ID: <50C246D9.8070304@iu.edu> Date: Fri, 07 Dec 2012 14:43:21 -0500 From: Marlon Pierce User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: dev@airavata.apache.org Subject: Re: saveWorkflow methods References: <64470FD7-2895-4983-B5C9-0C1C11AD2E6B@gmail.com> <3B55C77E-D39A-48CB-907D-A8722EAFFCA2@apache.org> In-Reply-To: <3B55C77E-D39A-48CB-907D-A8722EAFFCA2@apache.org> X-Enigmail-Version: 1.4.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 +1 for this review. Please schedule. Marlon On 12/7/12 2:09 PM, Suresh Marru wrote: > + 1 for a API review. How about we do it before we carve out the > 0.6 release? Just throwing a date, how about a google hangout on > Monday and post back the summary of the discussion to the mailing > list? > > Suresh > > On Dec 7, 2012, at 1:32 PM, Saminda Wijeratne > wrote: > >> Lahiru/Raminder, >> >> Can we also have a small review on the WorkflowManager while we >> are at this? If you can look at the existing API methods and give >> your feedback on how they can be improved on a developer >> perspective, the API will be more stable based on requirements. >> >> Saminda >> >> On Fri, Dec 7, 2012 at 10:13 AM, Lahiru Gunathilake >> wrote: >> >>> Yes I am +1 for this, but we need to change the workflow xml >>> before sending it to backend.. >>> >>> I will add this method to API.. as saveWorkflowWithName. >>> >>> Lahiru >>> >>> On Fri, Dec 7, 2012 at 10:03 AM, Raminderjeet Singh < >>> raminderjsingh@gmail.com> wrote: >>> >>>> As the Workflow XML is difficult to edit or user can make >>>> mistakes. Can >>> we >>>> have a API method to provide workflow name on upload? We can >>>> handle updating the workflowName tag in XML programmatically >>>> in that method. >>>> >>>> Thanks Raminder On Dec 7, 2012, at 9:56 AM, Lahiru >>>> Gunathilake wrote: >>>> >>>>> FYI, We are saving the workflow with the name in the >>>>> workflow (workflow file has an element called >>>>> workflowName). I will put some comments on >>> the >>>>> API and we should put some note on API docs too. >>>>> >>>>> Regards Lahiru >>>>> >>>>> On Thu, Dec 6, 2012 at 4:44 PM, Lahiru Gunathilake >>>>> >>>> >>>>>> Hi Devs, >>>>>> >>>>>> While I was working on some samples I realize >>>>>> saveWorkflow methods are >>>> not >>>>>> allowing users to give their own worklfow name or atleast >>>>>> its not >>>> returning >>>>>> workflow saved names. >>>>>> >>>>>> When we use the API we need to have the workflow name >>>>>> which got saved >>> in >>>>>> to registry. >>>>>> >>>>>> I think we should return workflow name as the return >>>>>> value of >>>> saveWorkflow >>>>>> methods and we need to provide another method to give >>>>>> user given >>>> workflow >>>>>> name to be provided. >>>>>> >>>>>> Please correct me if I am wrong. >>>>>> >>>>>> >>>>>> Regards Lahiru >>>>>> >>>>>> -- System Analyst Programmer PTI Lab Indiana University >>>>>> >>>>>> >>>>> >>>>> >>>>> -- System Analyst Programmer PTI Lab Indiana University >>>> >>>> >>> >>> >>> -- System Analyst Programmer PTI Lab Indiana University >>> > -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.16 (Darwin) Comment: Using GnuPG with undefined - http://www.enigmail.net/ iQEcBAEBAgAGBQJQwkbYAAoJEOEgD2XReDo5Z/MH/1Yw/ovqGnI02t9+yY0/CyMG UWLjl6fERGfKuk2SAIHrYbFn+Le36CIlitalAe2baMA1b5fCno2co/XrIpmTNXDh 6x+0kYc3x+ZPGBTjV6h/MV3jDcsrCzyZhZ3q6ErEjMnsIIvMEiOoC7F+Q+vlN0oL XryrUZkj+/er52PYg9A+OYcfJ5aMNEA+rlhj4D1JnNi7K90skH3Vdr5j8SFOvNQL xm+pKZLMiZFj89Na1ZCYLMuqtNfw7HInjzE8X5jD5w20VogPninRZPDzLwOaFYeK H0e+heT+A7OfEf48bLUj8jVFXx2vQO2jT4N/E6M2rLki2yOZg9y2sQ+PZJ6zpvs= =QJB9 -----END PGP SIGNATURE-----