airavata-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From machris...@apache.org
Subject [airavata-django-portal] 05/08: AIRAVATA-3016 Removing sanitizing usernames
Date Fri, 24 May 2019 18:28:41 GMT
This is an automated email from the ASF dual-hosted git repository.

machristie pushed a commit to branch airavata-3016
in repository https://gitbox.apache.org/repos/asf/airavata-django-portal.git

commit 68d736ec201e18a21187e6f71ff314ac367b560d
Author: Marcus Christie <machristie@apache.org>
AuthorDate: Fri May 24 11:10:46 2019 -0400

    AIRAVATA-3016 Removing sanitizing usernames
    
    Usernames should be safe for directory names already and
    sanitizing them this way will introduce an incompatibility for users
    with usernames that have an @ symbol in them.
---
 django_airavata/apps/api/datastore.py | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/django_airavata/apps/api/datastore.py b/django_airavata/apps/api/datastore.py
index 34d858e..a9b76c6 100644
--- a/django_airavata/apps/api/datastore.py
+++ b/django_airavata/apps/api/datastore.py
@@ -142,14 +142,9 @@ def path_(username, file_path):
     return user_data_storage.path(file_path)
 
 
-def _user_dir_name(username):
-    return Storage().get_valid_name(username)
-
-
 def _user_data_storage(username):
     return FileSystemStorage(
-        location=os.path.join(settings.GATEWAY_DATA_STORE_DIR,
-                              _user_dir_name(username)))
+        location=os.path.join(settings.GATEWAY_DATA_STORE_DIR, username))
 
 
 # from https://stackoverflow.com/a/1392549


Mime
View raw message