airavata-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From machris...@apache.org
Subject [airavata-django-portal] 04/05: AIRAVATA-2727 Removing TODOs
Date Fri, 17 Aug 2018 19:36:00 GMT
This is an automated email from the ASF dual-hosted git repository.

machristie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/airavata-django-portal.git

commit fd7c1d5f45113b38a7cbc7920391bbff4e25fe5c
Author: Marcus Christie <machrist@iu.edu>
AuthorDate: Fri Aug 17 15:21:38 2018 -0400

    AIRAVATA-2727 Removing TODOs
---
 .../admin/group_resource_preferences/ComputePreference.vue  | 12 ------------
 .../GroupComputeResourcePreference.vue                      | 13 ++-----------
 .../dashboards/ComputeResourcePreferenceDashboard.vue       |  8 ++------
 3 files changed, 4 insertions(+), 29 deletions(-)

diff --git a/django_airavata/apps/admin/static/django_airavata_admin/src/components/admin/group_resource_preferences/ComputePreference.vue
b/django_airavata/apps/admin/static/django_airavata_admin/src/components/admin/group_resource_preferences/ComputePreference.vue
index a43a971..0146a92 100644
--- a/django_airavata/apps/admin/static/django_airavata_admin/src/components/admin/group_resource_preferences/ComputePreference.vue
+++ b/django_airavata/apps/admin/static/django_airavata_admin/src/components/admin/group_resource_preferences/ComputePreference.vue
@@ -211,10 +211,6 @@
                   id: this.id
                 }
               });
-            })
-            .catch(error => {
-              // TODO: handle error
-              console.log("Error occurred", error);
             });
         } else {
           DjangoAiravataAPI.services.ServiceFactory.service("GroupResourceProfiles").create({data:
groupResourceProfile})
@@ -226,10 +222,6 @@
                   id: groupResourceProfile.groupResourceProfileId
                 }
               });
-            })
-            .catch(error => {
-              // TODO: handle error
-              console.log("Error occurred", error);
             });
         }
       },
@@ -247,10 +239,6 @@
                   id: this.id
                 }
               });
-            })
-            .catch(error => {
-              // TODO: handle error
-              console.log("Error occurred", error);
             });
         } else {
           // Since nothing was removed, just handle this like a cancel
diff --git a/django_airavata/apps/admin/static/django_airavata_admin/src/components/admin/group_resource_preferences/GroupComputeResourcePreference.vue
b/django_airavata/apps/admin/static/django_airavata_admin/src/components/admin/group_resource_preferences/GroupComputeResourcePreference.vue
index 206661e..8699553 100644
--- a/django_airavata/apps/admin/static/django_airavata_admin/src/components/admin/group_resource_preferences/GroupComputeResourcePreference.vue
+++ b/django_airavata/apps/admin/static/django_airavata_admin/src/components/admin/group_resource_preferences/GroupComputeResourcePreference.vue
@@ -147,7 +147,6 @@
               return this.$refs.shareButton.mergeAndSave(groupResourceProfileId);
             });
         }
-        // TODO: handle errors
         persist.then(data => {
           this.$router.push('/group-resource-profiles');
         });
@@ -192,21 +191,13 @@
         let groupResourceProfile = this.data.clone();
         groupResourceProfile.removeComputeResource(computeResourceId);
         this.service.update({data: groupResourceProfile, lookup: this.id})
-          .then(groupResourceProfile => this.data = groupResourceProfile)
-          .catch(error => {
-            // TODO: handle error
-            console.log("Error occurred", error);
-          });
+          .then(groupResourceProfile => this.data = groupResourceProfile);
       },
       removeGroupResourceProfile: function() {
         if (this.id) {
           this.service.delete({lookup: this.id})
             .then(() => {
               this.$router.push('/group-resource-profiles');
-            })
-            .catch(error => {
-              // TODO: handle error
-              console.log("Error occurred", error);
             });
         } else {
           // Nothing to delete so just treat like a cancel
@@ -215,4 +206,4 @@
       }
     },
   }
-</script>
\ No newline at end of file
+</script>
diff --git a/django_airavata/apps/admin/static/django_airavata_admin/src/components/dashboards/ComputeResourcePreferenceDashboard.vue
b/django_airavata/apps/admin/static/django_airavata_admin/src/components/dashboards/ComputeResourcePreferenceDashboard.vue
index bddae9a..a4548bd 100644
--- a/django_airavata/apps/admin/static/django_airavata_admin/src/components/dashboards/ComputeResourcePreferenceDashboard.vue
+++ b/django_airavata/apps/admin/static/django_airavata_admin/src/components/dashboards/ComputeResourcePreferenceDashboard.vue
@@ -73,15 +73,11 @@
 
         services.GroupResourceProfileService.delete({lookup: groupResourceProfile.groupResourceProfileId})
           .then(() => services.GroupResourceProfileService.list())
-          .then(groupResourceProfiles => this.groupResourceProfiles = groupResourceProfiles)
-          .catch(error => {
-            // TODO: handle error
-            console.log("Error occurred", error);
-          });
+          .then(groupResourceProfiles => this.groupResourceProfiles = groupResourceProfiles);
       }
     },
     mounted: function () {
       this.loadGroupResourceProfiles();
     }
   }
-</script>
\ No newline at end of file
+</script>


Mime
View raw message