Return-Path: 
 <commits-return-12774-apmail-airavata-commits-archive=airavata.apache.org@airavata.apache.org>
X-Original-To: apmail-airavata-commits-archive@www.apache.org
Delivered-To: apmail-airavata-commits-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 26B4D19BBE
	for <apmail-airavata-commits-archive@www.apache.org>;
 Fri, 25 Mar 2016 20:48:49 +0000 (UTC)
Received: (qmail 9770 invoked by uid 500); 25 Mar 2016 20:48:48 -0000
Delivered-To: apmail-airavata-commits-archive@airavata.apache.org
Received: (qmail 8980 invoked by uid 500); 25 Mar 2016 20:48:48 -0000
Mailing-List: contact commits-help@airavata.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:commits-help@airavata.apache.org>
List-Unsubscribe: <mailto:commits-unsubscribe@airavata.apache.org>
List-Post: <mailto:commits@airavata.apache.org>
List-Id: <commits.airavata.apache.org>
Reply-To: dev@airavata.apache.org
Delivered-To: mailing list commits@airavata.apache.org
Received: (qmail 7218 invoked by uid 99); 25 Mar 2016 20:48:47 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 25 Mar 2016 20:48:47 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id EE1EBE981E; Fri, 25 Mar 2016 20:48:46 +0000 (UTC)
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
From: scnakandala@apache.org
To: commits@airavata.apache.org
Date: Fri, 25 Mar 2016 20:49:07 -0000
Message-Id: <bb88e2432c764818bddfbf4aa4c6b162@git.apache.org>
In-Reply-To: <c9f037e190704e71a3f10e032b0c1b55@git.apache.org>
References: <c9f037e190704e71a3f10e032b0c1b55@git.apache.org>
X-Mailer: ASF-Git Admin Mailer
Subject: [22/40] airavata-php-gateway git commit: fixing html issue

fixing html issue


Project: http://git-wip-us.apache.org/repos/asf/airavata-php-gateway/repo
Commit: http://git-wip-us.apache.org/repos/asf/airavata-php-gateway/commit/69de925f
Tree: http://git-wip-us.apache.org/repos/asf/airavata-php-gateway/tree/69de925f
Diff: http://git-wip-us.apache.org/repos/asf/airavata-php-gateway/diff/69de925f

Branch: refs/heads/master
Commit: 69de925f56642219b11d06f2716125e56dd2e8b3
Parents: 7a825b3
Author: scnakandala <supun.nakandala@gmail.com>
Authored: Wed Mar 23 17:57:05 2016 -0400
Committer: scnakandala <supun.nakandala@gmail.com>
Committed: Wed Mar 23 17:57:05 2016 -0400

----------------------------------------------------------------------
 app/libraries/ExperimentUtilities.php | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/airavata-php-gateway/blob/69de925f/app/libraries/ExperimentUtilities.php
----------------------------------------------------------------------
diff --git a/app/libraries/ExperimentUtilities.php b/app/libraries/ExperimentUtilities.php
index 78403ac..41bb779 100644
--- a/app/libraries/ExperimentUtilities.php
+++ b/app/libraries/ExperimentUtilities.php
@@ -73,7 +73,6 @@ class ExperimentUtilities
             $order[$index] = $input->inputOrder;
         }
         array_multisort($order, SORT_ASC, $experimentInputs);
-        $html = "";
         foreach ($experimentInputs as $input) {
             $matchingAppInput = null;
 
@@ -92,14 +91,12 @@ class ExperimentUtilities
                 if(!ExperimentUtilities::endsWith($dataRoot, "/"))
                     $dataRoot += "/";
                 $filePath = str_replace($hostPathConstant . $dataRoot . Session::get('username'), "", $currentInputPath);
-                $html .= '<p><a target="_blank" href="' . URL::to("/") . '/download?path=' . $filePath . '>' . basename($filePath) . '<span class="glyphicon glyphicon-new-window"></span></a></p>';
+                echo '<p><a target="_blank" href="' . URL::to("/") . '/download/?path=' . $filePath . '">' . basename($filePath) . ' <span class="glyphicon glyphicon-new-window"></span></a></p>';
             } elseif ($input->type == DataType::STRING || $input->type == DataType::INTEGER
                 || $input->type == DataType::FLOAT) {
-                $html .= '<p>' . $input->name . ': ' . $input->value . '</p>';
+                echo '<p>' . $input->name . ': ' . $input->value . '</p>';
             }
         }
-
-        return $html;
     }
 
     private  static function endsWith($haystack, $needle) {