airavata-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From scnakand...@apache.org
Subject airavata-php-gateway git commit: fixing html issue
Date Wed, 23 Mar 2016 21:57:08 GMT
Repository: airavata-php-gateway
Updated Branches:
  refs/heads/develop 7a825b33b -> 69de925f5


fixing html issue


Project: http://git-wip-us.apache.org/repos/asf/airavata-php-gateway/repo
Commit: http://git-wip-us.apache.org/repos/asf/airavata-php-gateway/commit/69de925f
Tree: http://git-wip-us.apache.org/repos/asf/airavata-php-gateway/tree/69de925f
Diff: http://git-wip-us.apache.org/repos/asf/airavata-php-gateway/diff/69de925f

Branch: refs/heads/develop
Commit: 69de925f56642219b11d06f2716125e56dd2e8b3
Parents: 7a825b3
Author: scnakandala <supun.nakandala@gmail.com>
Authored: Wed Mar 23 17:57:05 2016 -0400
Committer: scnakandala <supun.nakandala@gmail.com>
Committed: Wed Mar 23 17:57:05 2016 -0400

----------------------------------------------------------------------
 app/libraries/ExperimentUtilities.php | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/airavata-php-gateway/blob/69de925f/app/libraries/ExperimentUtilities.php
----------------------------------------------------------------------
diff --git a/app/libraries/ExperimentUtilities.php b/app/libraries/ExperimentUtilities.php
index 78403ac..41bb779 100644
--- a/app/libraries/ExperimentUtilities.php
+++ b/app/libraries/ExperimentUtilities.php
@@ -73,7 +73,6 @@ class ExperimentUtilities
             $order[$index] = $input->inputOrder;
         }
         array_multisort($order, SORT_ASC, $experimentInputs);
-        $html = "";
         foreach ($experimentInputs as $input) {
             $matchingAppInput = null;
 
@@ -92,14 +91,12 @@ class ExperimentUtilities
                 if(!ExperimentUtilities::endsWith($dataRoot, "/"))
                     $dataRoot += "/";
                 $filePath = str_replace($hostPathConstant . $dataRoot . Session::get('username'),
"", $currentInputPath);
-                $html .= '<p><a target="_blank" href="' . URL::to("/") . '/download?path='
. $filePath . '>' . basename($filePath) . '<span class="glyphicon glyphicon-new-window"></span></a></p>';
+                echo '<p><a target="_blank" href="' . URL::to("/") . '/download/?path='
. $filePath . '">' . basename($filePath) . ' <span class="glyphicon glyphicon-new-window"></span></a></p>';
             } elseif ($input->type == DataType::STRING || $input->type == DataType::INTEGER
                 || $input->type == DataType::FLOAT) {
-                $html .= '<p>' . $input->name . ': ' . $input->value . '</p>';
+                echo '<p>' . $input->name . ': ' . $input->value . '</p>';
             }
         }
-
-        return $html;
     }
 
     private  static function endsWith($haystack, $needle) {


Mime
View raw message