Return-Path: X-Original-To: apmail-incubator-airavata-commits-archive@minotaur.apache.org Delivered-To: apmail-incubator-airavata-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 029DF8E4E for ; Wed, 7 Sep 2011 14:00:27 +0000 (UTC) Received: (qmail 67763 invoked by uid 500); 7 Sep 2011 14:00:26 -0000 Delivered-To: apmail-incubator-airavata-commits-archive@incubator.apache.org Received: (qmail 67695 invoked by uid 500); 7 Sep 2011 14:00:26 -0000 Mailing-List: contact airavata-commits-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: airavata-dev@incubator.apache.org Delivered-To: mailing list airavata-commits@incubator.apache.org Received: (qmail 67669 invoked by uid 99); 7 Sep 2011 14:00:26 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Sep 2011 14:00:26 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Sep 2011 14:00:23 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id C2CA223889B3; Wed, 7 Sep 2011 14:00:02 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1166188 - in /incubator/airavata/trunk/modules: commons/gfac-schema/src/main/java/org/apache/airavata/core/REVIEW.txt gfac-core/src/main/java/org/apache/airavata/core/gfac/context/GFACContext.java Date: Wed, 07 Sep 2011 14:00:02 -0000 To: airavata-commits@incubator.apache.org From: mpierce@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20110907140002.C2CA223889B3@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: mpierce Date: Wed Sep 7 14:00:02 2011 New Revision: 1166188 URL: http://svn.apache.org/viewvc?rev=1166188&view=rev Log: (RAVE-93) Some comments about package naming conventions that I found confusing. Added: incubator/airavata/trunk/modules/commons/gfac-schema/src/main/java/org/apache/airavata/core/REVIEW.txt Modified: incubator/airavata/trunk/modules/gfac-core/src/main/java/org/apache/airavata/core/gfac/context/GFACContext.java Added: incubator/airavata/trunk/modules/commons/gfac-schema/src/main/java/org/apache/airavata/core/REVIEW.txt URL: http://svn.apache.org/viewvc/incubator/airavata/trunk/modules/commons/gfac-schema/src/main/java/org/apache/airavata/core/REVIEW.txt?rev=1166188&view=auto ============================================================================== --- incubator/airavata/trunk/modules/commons/gfac-schema/src/main/java/org/apache/airavata/core/REVIEW.txt (added) +++ incubator/airavata/trunk/modules/commons/gfac-schema/src/main/java/org/apache/airavata/core/REVIEW.txt Wed Sep 7 14:00:02 2011 @@ -0,0 +1,7 @@ +I suggest renaming this directory and all the associated packages to be + +org/apache/airavata/commons/gfac + +or something like this. It is currently a little confusing to call this "core". For example, ParameterContextImpl.java in gfac-core uses AbstractParameter in commons. The naming convention implies AbstractParameter should be in gfac-core's module. + + Modified: incubator/airavata/trunk/modules/gfac-core/src/main/java/org/apache/airavata/core/gfac/context/GFACContext.java URL: http://svn.apache.org/viewvc/incubator/airavata/trunk/modules/gfac-core/src/main/java/org/apache/airavata/core/gfac/context/GFACContext.java?rev=1166188&r1=1166187&r2=1166188&view=diff ============================================================================== --- incubator/airavata/trunk/modules/gfac-core/src/main/java/org/apache/airavata/core/gfac/context/GFACContext.java (original) +++ incubator/airavata/trunk/modules/gfac-core/src/main/java/org/apache/airavata/core/gfac/context/GFACContext.java Wed Sep 7 14:00:02 2011 @@ -25,6 +25,11 @@ import org.apache.airavata.core.gfac.typ import org.apache.airavata.core.gfac.type.HostDescription; import org.apache.airavata.core.gfac.type.ServiceDescription; + +/** + * This class provides access to the Host, Application Deployment, and Service descriptions, which + * are XML<->JavaBean serializations. + */ public class GFACContext{ private HostDescription host; private ApplicationDeploymentDescription app;