airavata-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mpie...@apache.org
Subject svn commit: r1166188 - in /incubator/airavata/trunk/modules: commons/gfac-schema/src/main/java/org/apache/airavata/core/REVIEW.txt gfac-core/src/main/java/org/apache/airavata/core/gfac/context/GFACContext.java
Date Wed, 07 Sep 2011 14:00:02 GMT
Author: mpierce
Date: Wed Sep  7 14:00:02 2011
New Revision: 1166188

URL: http://svn.apache.org/viewvc?rev=1166188&view=rev
Log:
(RAVE-93) Some comments about package naming conventions that I found confusing.

Added:
    incubator/airavata/trunk/modules/commons/gfac-schema/src/main/java/org/apache/airavata/core/REVIEW.txt
Modified:
    incubator/airavata/trunk/modules/gfac-core/src/main/java/org/apache/airavata/core/gfac/context/GFACContext.java

Added: incubator/airavata/trunk/modules/commons/gfac-schema/src/main/java/org/apache/airavata/core/REVIEW.txt
URL: http://svn.apache.org/viewvc/incubator/airavata/trunk/modules/commons/gfac-schema/src/main/java/org/apache/airavata/core/REVIEW.txt?rev=1166188&view=auto
==============================================================================
--- incubator/airavata/trunk/modules/commons/gfac-schema/src/main/java/org/apache/airavata/core/REVIEW.txt
(added)
+++ incubator/airavata/trunk/modules/commons/gfac-schema/src/main/java/org/apache/airavata/core/REVIEW.txt
Wed Sep  7 14:00:02 2011
@@ -0,0 +1,7 @@
+I suggest renaming this directory and all the associated packages to be 
+
+org/apache/airavata/commons/gfac 
+
+or something like this.  It is currently a little confusing to call this "core".  For example,
ParameterContextImpl.java in gfac-core uses AbstractParameter in commons.  The naming convention
implies AbstractParameter should be in gfac-core's module.
+
+ 

Modified: incubator/airavata/trunk/modules/gfac-core/src/main/java/org/apache/airavata/core/gfac/context/GFACContext.java
URL: http://svn.apache.org/viewvc/incubator/airavata/trunk/modules/gfac-core/src/main/java/org/apache/airavata/core/gfac/context/GFACContext.java?rev=1166188&r1=1166187&r2=1166188&view=diff
==============================================================================
--- incubator/airavata/trunk/modules/gfac-core/src/main/java/org/apache/airavata/core/gfac/context/GFACContext.java
(original)
+++ incubator/airavata/trunk/modules/gfac-core/src/main/java/org/apache/airavata/core/gfac/context/GFACContext.java
Wed Sep  7 14:00:02 2011
@@ -25,6 +25,11 @@ import org.apache.airavata.core.gfac.typ
 import org.apache.airavata.core.gfac.type.HostDescription;
 import org.apache.airavata.core.gfac.type.ServiceDescription;
 
+
+/**
+ * This class provides access to the Host, Application Deployment, and Service descriptions,
which
+ * are XML<->JavaBean serializations. 
+ */ 
 public class GFACContext{
     private HostDescription host;
     private ApplicationDeploymentDescription app;



Mime
View raw message