airavata-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mpie...@apache.org
Subject svn commit: r1166168 - /incubator/airavata/trunk/modules/gfac-core/src/main/java/org/apache/airavata/core/gfac/context/REVIEW.txt
Date Wed, 07 Sep 2011 13:26:31 GMT
Author: mpierce
Date: Wed Sep  7 13:26:30 2011
New Revision: 1166168

URL: http://svn.apache.org/viewvc?rev=1166168&view=rev
Log:
(Airavata-93) Some review comments about the context directory organization.  


Added:
    incubator/airavata/trunk/modules/gfac-core/src/main/java/org/apache/airavata/core/gfac/context/REVIEW.txt

Added: incubator/airavata/trunk/modules/gfac-core/src/main/java/org/apache/airavata/core/gfac/context/REVIEW.txt
URL: http://svn.apache.org/viewvc/incubator/airavata/trunk/modules/gfac-core/src/main/java/org/apache/airavata/core/gfac/context/REVIEW.txt?rev=1166168&view=auto
==============================================================================
--- incubator/airavata/trunk/modules/gfac-core/src/main/java/org/apache/airavata/core/gfac/context/REVIEW.txt
(added)
+++ incubator/airavata/trunk/modules/gfac-core/src/main/java/org/apache/airavata/core/gfac/context/REVIEW.txt
Wed Sep  7 13:26:30 2011
@@ -0,0 +1,16 @@
+I think this directory structure could use some revision since it mixes classes and interfaces.
 I suggest making some directories to group these:
+
+org/apache/airavata/core/gfac/context/security/
+org/apache/airavata/core/gfac/context/messaging/
+org/apache/airavata/core/gfac/context/execution/
+org/apache/airavata/core/gfac/context/invocation/
+
+
+Each of these should have an "impl" sub-directory and a "utils" sub-sub-directory.  For example,
AmazonSecurityContext.java belongs in org/apache/airavata/core/gfac/context/security/impl
in this scheme.  
+
+Also, even though they are simple, I recommend converting InvocationContext and GFACContext
classes to abstract and then putting implementations (DefaultInvocationContext and DefaultGFACContext)
in the appropriate impl directory.
+
+
+
+
+



Mime
View raw message