Mailing-List: contact users-help@activemq.apache.org; run by ezmlm
Precedence: bulk
Reply-To: users@activemq.apache.org
MIME-Version: 1.0
In-Reply-To: <CAM1CxXDqcokCZQtd=AMm9rD06Vz-81Z3XiMPT=E71+MhsPq95g@mail.gmail.com>
References: <1502366449346-4729594.post@n4.nabble.com> <CAM1CxXBTbKOMp=rfLt3aYx+88i960Pd7fuNXR8zsORFtmOmaGg@mail.gmail.com>
 <CAF+kE=QDF7q8ZgtzX1pPRiX9+noBjD6FmnRv5-EXWoNDgiXr_g@mail.gmail.com> <CAM1CxXDqcokCZQtd=AMm9rD06Vz-81Z3XiMPT=E71+MhsPq95g@mail.gmail.com>
From: Justin Bertram <jbertram@redhat.com>
Date: Mon, 14 Aug 2017 14:08:47 -0500
Message-ID: <CAF+kE=SAYCPQtVu14WbE08g-BgBw1b+ZAzhP8Tt3-Yt5rX9iMQ@mail.gmail.com>
Subject: Re: Intercept mqtt client connection
To: users@activemq.apache.org
Content-Type: multipart/alternative; boundary="001a113d4d6e706c970556bb643e"
archived-at: Mon, 14 Aug 2017 19:08:57 -0000

--001a113d4d6e706c970556bb643e
Content-Type: text/plain; charset="UTF-8"

Take a look
at org.apache.activemq.artemis.core.protocol.core.impl.ChannelImpl#invokeInterceptors.
I think the MQTT and STOMP protocol managers should be calling that instead
of invoking the interceptors themselves.


Justin

On Mon, Aug 14, 2017 at 1:38 PM, Otavio Piske <opiske@redhat.com> wrote:

> +1 for adding it, unless there's a reason not to.
>
> I'm playing w/ the code for this and will send a PR sometime this week.
>
> On Mon, Aug 14, 2017 at 7:29 PM, Justin Bertram <jbertram@redhat.com>
> wrote:
>
> > > I believe it's because it's not implemented.
> >
> > Agreed.  It looks to me like only the publish packets are intercepted
> > currently.  Unless this was done very specifically then I think the logic
> > should be modified to intercept all kinds of packets.
> >
> >
> > Justin
> >
> > On Mon, Aug 14, 2017 at 12:23 PM, Otavio Piske <opiske@redhat.com>
> wrote:
> >
> > > I believe it's because it's not implemented.
> > >
> > > I did a small modification to the code to test this hypothesis:
> > > https://github.com/orpiske/activemq-artemis/commit/
> > > bd57548b6b2897a436240d6abadc1a8e01a1acc9.
> > >
> > >
> > > After that, it can intercept Connect control packets.
> > >
> > > On Thu, Aug 10, 2017 at 2:00 PM, aragoubi <aymen.rag@gmail.com> wrote:
> > >
> > > > I added an mqtt interceptor into my artemis broker in order to
> > intercept
> > > > mqtt
> > > > client connection:
> > > >
> > > >
> > > >
> > > > /public class SimpleMQTTInterceptor implements MQTTInterceptor
> > > > {
> > > >         @Override
> > > >         public boolean intercept(final MqttMessage mqttMessage,
> > > > RemotingConnection
> > > > connection) throws ActiveMQException
> > > >         {
> > > >                 System.out.println("MQTT Interceptor gets called ");
> > > >
> > > >                 if (mqttMessage instanceof MqttConnectMessage)
> > > >                 {
> > > >                         System.out.println("MQTT connection
> intercepted
> > > ");
> > > >                 }
> > > >                 return true;
> > > >         }
> > > > }/
> > > >
> > > > My problem is that only message published to topics are intercepted.
> > > > Why this doesn't intercept *CONNECT* message ?
> > > >
> > > >
> > > >
> > > >
> > > > --
> > > > View this message in context: http://activemq.2283324.n4.
> > > > nabble.com/Intercept-mqtt-client-connection-tp4729594.html
> > > > Sent from the ActiveMQ - User mailing list archive at Nabble.com.
> > > >
> > >
> > >
> > >
> > > --
> > > Otavio R. Piske
> > > Messaging Quality Assurance Engineer
> > >
> >
>
>
>
> --
> Otavio R. Piske
> Messaging Quality Assurance Engineer
>

--001a113d4d6e706c970556bb643e--