Mailing-List: contact users-help@activemq.apache.org; run by ezmlm
Precedence: bulk
Reply-To: users@activemq.apache.org
MIME-Version: 1.0
Sender: burtonator2011@gmail.com
In-Reply-To: 
 <CAEc5pW3LtAKLM_TmZ8nxfKMfq7xPLxZkxCjPhOTfc3+c+61Csw@mail.gmail.com>
References: 
 <CAAZU44nWuGTi2fBx8o7h4fkcZ9qd8jF53FZdqCeUW00rYNpW5w@mail.gmail.com>
	<CAPVVMa-MbVC5bnVHv33Hv-XrTOtaZHb5zx5gp+1o31hP0Sxmhw@mail.gmail.com>
	<CAAZU44mcc7bEwpGc3KYBMzjVyNnjv+wm-4CjbLgdFFyY8dY2gw@mail.gmail.com>
	<CAEc5pW3LtAKLM_TmZ8nxfKMfq7xPLxZkxCjPhOTfc3+c+61Csw@mail.gmail.com>
Date: Tue, 2 Jun 2015 08:16:30 -0700
Message-ID: 
 <CAAZU44nDiQOf9qdeuar4+MvFVgd1NOmbSz_dTha=6DUkgG2CRg@mail.gmail.com>
Subject: Re: More ActiveMQ hotspots.. courtesy of continuous profiling :)
From: Kevin Burton <burton@spinn3r.com>
To: users@activemq.apache.org
Content-Type: multipart/alternative; boundary=089e0139fe6063f7d805178a6ddc

--089e0139fe6063f7d805178a6ddc
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Both are decent... Just not really for production use. One of the cool
things about java mission control is the overhead is only about one
percent. I would love to see other profilers catch  up.
On Jun 2, 2015 7:26 AM, "Thiago Kronig" <thiagokronig@gmail.com> wrote:

> YourKit <https://www.yourkit.com/> and JProfiler <
> http://www.ej-technologies.com/products/jprofiler/overview.html> are grea=
t
> commercial tools, and they have licenses for open source projects.
>
> On Tue, Jun 2, 2015 at 11:19 AM Kevin Burton <burton@spinn3r.com> wrote:
>
> > On Tue, Jun 2, 2015 at 6:16 AM, Tim Bain <tbain@alumni.duke.edu> wrote:
> >
> > > Kevin,
> > >
> > > Great finds.  What tool were you using?
> > >
> > >
> > Java Mission Control.. Free for development.. but I think the community
> > needs a real open source tool.  Pseudo -free isn=E2=80=99t a good idea.
> >
> >
> > > Is it safe to assume you'll submit patches (when you have time) so we
> > don't
> > > need to capture these in JIRA?
> > >
> >
> > Might want to create one.  The problem with my patch set, is that I=E2=
=80=99m
> still
> > stuck on 5.10.2.  There=E2=80=99s a bug introduced sometime around 5.11=
 that only
> > impacts the memory store.  I haven=E2=80=99t been able to track it down=
 yet so I
> > can=E2=80=99t retarget my patches to head.  That, and I think one of my=
 patches
> > doesn=E2=80=99t work with LevelDB so I need to fix that.
> >
> > Realistically, I should fix all those issues so that I can move between
> > versions.
> >
> >
> > >
> > > Adding a synchronized Multimap<Consumer, Subscription> to
> > > ManagedRegionBroker looked good to me.  It won't be threadsafe agains=
t
> > > simultaneous registers/unregisters for the same subscription, but it
> > looks
> > > like that class already has that problem so I don't think that's a
> reason
> > > not to do it.
> > >
> >
> > Or store a second concurrent hash map.  that would fix it.
> >
> >
> > >
> > > In addConsumerToList(), I think we can do a sorted insertion (iterate
> > > through the list till you find the right place based on the comparato=
r,
> > > then insert) to skip the re-sort.  Either we'll be rolling the list o=
r
> we
> > > won't, but either way the list will be in sorted order, except that t=
he
> > > minimum element might not be the first one.  So find the minimum
> > element's
> > > index (O(log N), but can be optimized to O(1) for the not-rolling
> case),
> > > then do a sorted insert starting at that index and wrapping if
> necessary.
> >
> >
> > True.. That would definitely make that faster.
> >
> > Kevin
> > --
> >
> > Founder/CEO Spinn3r.com
> > Location: *San Francisco, CA*
> > blog: http://burtonator.wordpress.com
> > =E2=80=A6 or check out my Google+ profile
> > <https://plus.google.com/102718274791889610666/posts>
> >
>

--089e0139fe6063f7d805178a6ddc--