Mailing-List: contact users-help@activemq.apache.org; run by ezmlm
Precedence: bulk
Reply-To: users@activemq.apache.org
MIME-Version: 1.0
Sender: burtonator2011@gmail.com
In-Reply-To: 
 <CAH+vQmNijfQb-Pp0J0kbKKcVdmFTDjNcEPpRbRrBFxEy5D4gHg@mail.gmail.com>
References: 
 <CAAZU44k-01A9p57WK8BUYLvyDasmFCK8iRu_Gd3qFLbrGMFhfA@mail.gmail.com>
 <CAH+vQmNijfQb-Pp0J0kbKKcVdmFTDjNcEPpRbRrBFxEy5D4gHg@mail.gmail.com>
From: Kevin Burton <burton@spinn3r.com>
Date: Fri, 8 May 2015 10:33:18 -0700
Message-ID: 
 <CAAZU44=ZV9FrVVTDZ-ngaMJvW8H3cGJO+FBwRwVfauBj58L5yQ@mail.gmail.com>
Subject: 
 =?UTF-8?Q?Re=3A_=E2=80=9CUsage=22_and_other_performance_improvements_by_?=
	=?UTF-8?Q?avoiding_CopyOnWriteArrayList=2E?=
To: users@activemq.apache.org
Content-Type: multipart/alternative; boundary=001a113d606ac254780515956db1

--001a113d606ac254780515956db1
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Sounds good. I have one more small change to logging and I=E2=80=99ll submi=
t a PR.

On Thu, May 7, 2015 at 5:38 AM, Gary Tully <gary.tully@gmail.com> wrote:

> those changes look ok to me, as in they won't break anything and you
> have numbers that can make your case. Please splash in a patch or PR.
>
> On 2 May 2015 at 23:08, Kevin Burton <burton@spinn3r.com> wrote:
> > I=E2=80=99ve found 3 places where CopyOnWriteArrayList was being used a=
nd causing
> > significant performance impact O(N^2) when using large numbers of queue=
s.
> >
> > Could I get feedback on these 3 changes?
> >
> >
> https://github.com/spinn3r/activemq/commit/06ebfbf2a4d9201b57069644bdb7eb=
8274da0714
> >
> >
> https://github.com/spinn3r/activemq/commit/13f606d597b826f5a998866e0fe63e=
63aa278a24
> >
> > In both of these situations, I think a Set is a better idea than a List=
.
> > First, it=E2=80=99s faster.  Second, why would we want to cousin someth=
ing twice?
> > That=E2=80=99s the only reason I would think a List would be used inste=
ad of a
> Set.
> >
> >
> >
> > --
> >
> > Founder/CEO Spinn3r.com
> > Location: *San Francisco, CA*
> > blog: http://burtonator.wordpress.com
> > =E2=80=A6 or check out my Google+ profile
> > <https://plus.google.com/102718274791889610666/posts>
>


--=20

Founder/CEO Spinn3r.com
Location: *San Francisco, CA*
blog: http://burtonator.wordpress.com
=E2=80=A6 or check out my Google+ profile
<https://plus.google.com/102718274791889610666/posts>

--001a113d606ac254780515956db1--