activemq-users mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Tully <gary.tu...@gmail.com>
Subject Re: “Usage" and other performance improvements by avoiding CopyOnWriteArrayList.
Date Thu, 07 May 2015 12:38:31 GMT
those changes look ok to me, as in they won't break anything and you
have numbers that can make your case. Please splash in a patch or PR.

On 2 May 2015 at 23:08, Kevin Burton <burton@spinn3r.com> wrote:
> I’ve found 3 places where CopyOnWriteArrayList was being used and causing
> significant performance impact O(N^2) when using large numbers of queues.
>
> Could I get feedback on these 3 changes?
>
> https://github.com/spinn3r/activemq/commit/06ebfbf2a4d9201b57069644bdb7eb8274da0714
>
> https://github.com/spinn3r/activemq/commit/13f606d597b826f5a998866e0fe63e63aa278a24
>
> In both of these situations, I think a Set is a better idea than a List.
> First, it’s faster.  Second, why would we want to cousin something twice?
> That’s the only reason I would think a List would be used instead of a Set.
>
>
>
> --
>
> Founder/CEO Spinn3r.com
> Location: *San Francisco, CA*
> blog: http://burtonator.wordpress.com
> … or check out my Google+ profile
> <https://plus.google.com/102718274791889610666/posts>

Mime
View raw message