activemq-users mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Allen Reese <are...@yahoo-inc.com>
Subject RE: ActiveMQ watchdog for a production environment
Date Wed, 09 Mar 2011 00:56:48 GMT
Here is a fixed patch.
https://issues.apache.org/jira/secure/attachment/12473081/amq-298.patch

I can't figure out how to remove the first patch.

--Allen 

> -----Original Message-----
> From: Bruce Snyder [mailto:bruce.snyder@gmail.com] 
> Sent: Monday, March 07, 2011 12:25 PM
> To: users@activemq.apache.org
> Subject: Re: ActiveMQ watchdog for a production environment
> 
> On Mon, Mar 7, 2011 at 12:31 PM, Bruce Snyder 
> <bruce.snyder@gmail.com> wrote:
> > On Mon, Mar 7, 2011 at 11:50 AM, Allen Reese 
> <areese@yahoo-inc.com> wrote:
> >> At Yahoo!, we use jsvc to run activemq: 
> >> http://commons.apache.org/daemon/jsvc.html
> >>
> >> This JIRA has the java patches required to use jsvc:
> >> https://issues.apache.org/jira/browse/AMQ-2968
> >>
> >> However there are no start/stop scripts.  Our environment 
> is a little different with respect to start/stop scripts, so 
> the scripts we use are not usable by others.
> >
> > Thanks for the contribution, Allen!
> >
> > While preparing your patch to be committed to the trunk, I realized 
> > that commons-daemon-1.0.4.jar is not published to Maven 
> Central. But 
> > commons-daemon-1.0.3.jar is published and your patch builds 
> fine with 
> > this version. So I'm going to commit it using 1.0.3, is 
> that OK with 
> > you?
> 
> Allen, a couple things I just noticed in examining the patch closer:
> 
> 1) You did check the box to allow your patch to be included 
> in ASF works
> 2) But there is a copyright notice in the Java source file
> 
> Per the ASF policies, a copyright in a project's NOTICE file 
> is fine, but we don't place copyrights in the source files. 
> For more details, please see the following, specifically 1.1 and 1.2:
> 
> http://www.apache.org/legal/src-headers.html#headers
> 
> Furthermore, item 2 on that same page shows the appropriate 
> Apache License blurb that should be included in source files.
> 
> It would be great if you could attach a new patch to the issue that:
> a) removes the copyright from the Java source file, and, b) 
> includes the proper license header.
> 
> Bruce
> --
> perl -e 'print 
> unpack("u30","D0G)U8V4\@4VYY9&5R\"F)R=6-E+G-N>61E<D\!G;6%I;\"YC;VT*"
> );'
> 
> ActiveMQ in Action: http://bit.ly/2je6cQ
> Blog: http://bruceblog.org/
> Twitter: http://twitter.com/brucesnyder
> 
Mime
View raw message