Mailing-List: contact users-help@activemq.apache.org; run by ezmlm
Precedence: bulk
Reply-To: users@activemq.apache.org
Received-SPF: pass (athena.apache.org: domain of gary.tully@gmail.com
 designates 74.125.83.43 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type:content-transfer-encoding;
        b=LT5MJe3zQkgls7RR43J0Y3vRwuv99EqEr2YhGRbbJzV+DGzlt7Li72lAINIw3e4nNM
         74YYUsVgtwvU2sVQvDqCeQNkePDCJvMpeihZE0CdqpRUU7NvJTDCz6GkAnL8msA6Ckdw
         e592NHCW0gMJutvE9M5dSHiie4aI77a9oQeaM=
MIME-Version: 1.0
In-Reply-To: <1291742967069-3076846.post@n4.nabble.com>
References: <1291671397836-3075377.post@n4.nabble.com>
	<1291671892.2431.21.camel@office>
	<AANLkTi=cZvER1oR253FSs+dzzyqbrsn6QGnAZLy7h1eQ@mail.gmail.com>
	<444005.53382.qm@web53804.mail.re2.yahoo.com>
	<1291681339184-3075590.post@n4.nabble.com>
	<AANLkTi=F-LRT+fjWxcgS9TSutDxCB_43NmQYHr1VC0pm@mail.gmail.com>
	<1291742967069-3076846.post@n4.nabble.com>
Date: Wed, 8 Dec 2010 13:09:51 +0000
Message-ID: <AANLkTik=VK-GOUo01sQsnZ44Px8J+4qhurGepk_cejRf@mail.gmail.com>
Subject: Re: [5.4.2] New XML config issue? Not backward compatible?
From: Gary Tully <gary.tully@gmail.com>
To: users@activemq.apache.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Can you raise a jira issue to track this, it points to a problem with
the query parsing, it is typically called with the query string minus
the leading '?' but is attempting to jump to the last '?' which is
causing it to pick up the wrong parameter.

from a cursory look, the fix is:

Index: src/main/java/org/apache/activemq/util/URISupport.java
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- src/main/java/org/apache/activemq/util/URISupport.java	(revision 104316=
2)
+++ src/main/java/org/apache/activemq/util/URISupport.java	(working copy)
@@ -103,7 +103,7 @@

     public static Map<String, String> parseQuery(String uri) throws
URISyntaxException {
         try {
-            uri =3D uri.substring(uri.lastIndexOf("?") + 1); // get
only the relevant part of the query
+            //uri =3D uri.substring(uri.lastIndexOf("?") + 1); // get
only the relevant part of the query
             Map<String, String> rc =3D new HashMap<String, String>();
             if (uri !=3D null) {
                 String[] parameters =3D uri.split("&");

On 7 December 2010 17:29, benoitx <benoitx@yahoo.com> wrote:
>
> Hi Dejan
>
> Thanks for this... was obvious but..didn't spot it.
>
> Having said that it still does NOT work with
>
> vm://localhost?brokerConfig=3Dxbean:appendium-esb-server-activemq-broker-=
config.xml%3Fvalidate=3Dfalse
>
> I get an exception:
>
> java.lan.IllegalArgumentException: Invalid connect parameters:
> {validate=3Dfalse} at
> org.apache.activemq.transport.vm.VMTransportFactory.doCompositeConnect( l=
ine
> 155 )
> org.apache.activemq.transport.vm.VMTransportFactory.doConnect( line 53 )
> etc
>
> Is there a way to stop the validation (which only appeared with 5.4.2)
> whislt setting it up via the VM transport?
>
> Many thanks
>
> Benoit
>
>
>
> Dejan Bosanac wrote:
>>
>> This you should properly escape the inner url (convert ? to %3F). Can
>> you try something like
>>
>> vm://localhost?brokerConfig=3Dxbean:appendium-esb-server-activemq-broker=
-config.xml%3Fvalidate=3Dfalse
>>
>>
>> Cheers
>> --
>> Dejan Bosanac
>> -----------------
>> FuseSource - The experts in open source integration and messaging.
>> Email: dejanb@fusesource.com
>> Web: http://fusesource.com
>> Twitter: =A0http://twitter.com/dejanb
>> ActiveMQ in Action - http://www.manning.com/snyder/
>> Blog - http://www.nighttale.net
>>
>>
>>
>> On Mon, Dec 6, 2010 at 7:22 PM, benoitx <benoitx@yahoo.com> wrote:
>>>
>>> Sorry to come back on this... When we set this up via Spring XML, the
>>> validate=3Dfalse does not seem to work:
>>>
>>>
>>> =A0 =A0<bean id=3D"amqConnectionFactory"
>>> class=3D"org.apache.activemq.ActiveMQConnectionFactory">
>>> =A0 =A0 =A0 =A0<constructor-arg
>>> value=3D"vm://localhost?brokerConfig=3Dxbean:appendium-esb-server-activ=
emq-broker-config.xml?validate=3Dfalse"
>>> />
>>> =A0 =A0 =A0 =A0<property name=3D"redeliveryPolicy">
>>> =A0 =A0 =A0 =A0 =A0 =A0<bean class=3D"org.apache.activemq.RedeliveryPol=
icy">
>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0<!-- assuming one re-try per second this=
 amounts to 24
>>> hours
>>> -->
>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0<property name=3D"maximumRedeliveries" v=
alue=3D"86400" />
>>> =A0 =A0 =A0 =A0 =A0 =A0</bean>
>>> =A0 =A0 =A0 =A0</property>
>>> =A0 =A0</bean>
>>>
>>> we seem to get this:
>>>
>>>
>>> 2010-12-07 00:17:29,558 ERROR [notifiers.ConnectNotifier#?]
>>> (WrapperListener_start_runner:) Failed to connect/reconnect:
>>> ActiveMQJmsConnector{this=3D3d31f2b4, started=3Dfalse, initialised=3Dtr=
ue,
>>> name=3D'Ap_jmsConnector', disposed=3Dfalse,
>>> numberOfConcurrentTransactedReceivers=3D4,
>>> createMultipleTransactedReceivers=3Dtrue, connected=3Dfalse,
>>> supportedProtocols=3D[jms], serviceOverrides=3Dnull}. Root Exception wa=
s:
>>> Invalid connect parameters: {validate=3Dfalse}. Type: class
>>> java.lang.IllegalArgumentException
>>>
>>> Any suggestion welcome...
>>>
>>> Thanks!
>>>
>>> Benoit
>>> --
>>> View this message in context:
>>> http://activemq.2283324.n4.nabble.com/5-4-2-New-XML-config-issue-Not-ba=
ckward-compatible-tp3075377p3075590.html
>>> Sent from the ActiveMQ - User mailing list archive at Nabble.com.
>>>
>>
>>
>
> --
> View this message in context: http://activemq.2283324.n4.nabble.com/5-4-2=
-New-XML-config-issue-Not-backward-compatible-tp3075377p3076846.html
> Sent from the ActiveMQ - User mailing list archive at Nabble.com.
>


--=20
http://blog.garytully.com
http://fusesource.com