activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (ARTEMIS-2170) Optimized CoreMessage's checkProperties and cleanupInternalProperties methods
Date Mon, 21 Jan 2019 15:46:08 GMT

     [ https://issues.apache.org/jira/browse/ARTEMIS-2170?focusedWorklogId=187821&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-187821
]

ASF GitHub Bot logged work on ARTEMIS-2170:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 21/Jan/19 15:45
            Start Date: 21/Jan/19 15:45
    Worklog Time Spent: 10m 
      Work Description: michaelandrepearce commented on issue #2427: ARTEMIS-2170 Optimized
CoreMessage's checkProperties and cleanupInternalProperties methods
URL: https://github.com/apache/activemq-artemis/pull/2427#issuecomment-456115918
 
 
   > @michaelandrepearce I have checked that is not less optimized because the original
version was failing to find the prefixed properties to remove ie was looping every property
with a slower method
   
   Reply, is there a test proving that? Im very suprised, as i can see that the internal flag
when debugging master is being set correctly if i set one of those two headers, and i can
see it only goes into iterating if it has been set. So if they arent set no iterating occurs.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 187821)
    Time Spent: 1h 50m  (was: 1h 40m)

> Optimized CoreMessage's checkProperties and cleanupInternalProperties methods
> -----------------------------------------------------------------------------
>
>                 Key: ARTEMIS-2170
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2170
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>          Components: Broker
>            Reporter: Francesco Nigro
>            Assignee: Francesco Nigro
>            Priority: Minor
>          Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> CoreMessage::checkProperties perform too many volatile read/write and has a too big body
just to handle exceptional cases, while cleanupInternalProperties is called on the hot path
of session send, but is performing too many synchronized operations and loopup on TypedProperties.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message