From issues-return-28379-archive-asf-public=cust-asf.ponee.io@activemq.apache.org Wed May 16 14:27:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 07441180671 for ; Wed, 16 May 2018 14:27:03 +0200 (CEST) Received: (qmail 22142 invoked by uid 500); 16 May 2018 12:27:03 -0000 Mailing-List: contact issues-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list issues@activemq.apache.org Received: (qmail 22133 invoked by uid 99); 16 May 2018 12:27:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 16 May 2018 12:27:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 96A9218000F for ; Wed, 16 May 2018 12:27:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id J8LWC0DFdiPp for ; Wed, 16 May 2018 12:27:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 1C2995F216 for ; Wed, 16 May 2018 12:27:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 5D397E0110 for ; Wed, 16 May 2018 12:27:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 26967217A0 for ; Wed, 16 May 2018 12:27:00 +0000 (UTC) Date: Wed, 16 May 2018 12:27:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@activemq.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ARTEMIS-1868) Openwire doesn't add delivery count in client ack mode MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ARTEMIS-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477327#comment-16477327 ] ASF GitHub Bot commented on ARTEMIS-1868: ----------------------------------------- Github user gaohoward commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2090#discussion_r188604772 --- Diff: artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/amq/AMQSession.java --- @@ -308,6 +312,8 @@ public int sendMessage(MessageReference reference, ServerConsumer consumer, int deliveryCount) { AMQConsumer theConsumer = (AMQConsumer) consumer.getProtocolData(); + //clear up possible rolledback ids. + rollbackedIds.remove(message.getMessageID()); --- End diff -- Yes I know this adds some costs. But so far I couldn't have a better solution. > Openwire doesn't add delivery count in client ack mode > ------------------------------------------------------ > > Key: ARTEMIS-1868 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1868 > Project: ActiveMQ Artemis > Issue Type: Test > Components: OpenWire > Affects Versions: 2.5.0 > Reporter: Howard Gao > Assignee: Howard Gao > Priority: Major > Fix For: 2.5.1 > > > If a client ack mode consumer receives a message and closes without acking it, the redelivery of the message won't set the redelivery flag (JMSRedelivered) because it doesn't increment the delivery count when message is cancelled back to queue. -- This message was sent by Atlassian JIRA (v7.6.3#76005)