activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARTEMIS-1868) Openwire doesn't add delivery count in client ack mode
Date Wed, 16 May 2018 12:27:00 GMT

    [ https://issues.apache.org/jira/browse/ARTEMIS-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477327#comment-16477327
] 

ASF GitHub Bot commented on ARTEMIS-1868:
-----------------------------------------

Github user gaohoward commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2090#discussion_r188604772
  
    --- Diff: artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/amq/AMQSession.java
---
    @@ -308,6 +312,8 @@ public int sendMessage(MessageReference reference,
                               ServerConsumer consumer,
                               int deliveryCount) {
           AMQConsumer theConsumer = (AMQConsumer) consumer.getProtocolData();
    +      //clear up possible rolledback ids.
    +      rollbackedIds.remove(message.getMessageID());
    --- End diff --
    
    Yes I know this adds some costs. But so far I couldn't have a better solution.


> Openwire doesn't add delivery count in client ack mode
> ------------------------------------------------------
>
>                 Key: ARTEMIS-1868
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1868
>             Project: ActiveMQ Artemis
>          Issue Type: Test
>          Components: OpenWire
>    Affects Versions: 2.5.0
>            Reporter: Howard Gao
>            Assignee: Howard Gao
>            Priority: Major
>             Fix For: 2.5.1
>
>
> If a client ack mode consumer receives a message and closes without acking it, the redelivery
of the message won't set the redelivery flag (JMSRedelivered) because it doesn't increment
the delivery count when message is cancelled back to queue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message