activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (ARTEMIS-1862) fix acceptor config default for 'amqpLowCredits' and update related code defaults
Date Fri, 11 May 2018 20:13:00 GMT


ASF GitHub Bot commented on ARTEMIS-1862:

GitHub user gemmellr opened a pull request:

    ARTEMIS-1862: fix 'amqpLowCredits' XML config, update code defaults

    More details at

You can merge this pull request into a Git repository by running:

    $ git pull ARTEMIS-1862

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2088
commit f0bac1bf186aa84f53e72a3d72db307a04b8d2a2
Author: Robbie Gemmell <robbie@...>
Date:   2018-05-11T20:07:02Z

    ARTEMIS-1862: fix 'amqpLowCredits' XML config, update related code defaults


> fix acceptor config default for 'amqpLowCredits' and update related code defaults
> ---------------------------------------------------------------------------------
>                 Key: ARTEMIS-1862
>                 URL:
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: AMQP
>    Affects Versions: 2.5.0
>            Reporter: Robbie Gemmell
>            Priority: Major
> The brokers AMQP protocol support has configurable 'amqpCredits' and 'amqpLowCredits'
values to govern the amount of credit given to a producer at a time and when it is refreshed.
The broker.xml files appears to set these to values of 1000 and 300 respectively by default,
while the code has default values of 100 and 30 instead.
> The XML configuration for the 'amqp' acceptor (using the AMQP port, 5672) has incorrectly
had the value 'amqpMinCredits' applied rather than 'amqpLowCredits' as required and used on
the 'artemis' acceptor, and as result this has no effect and the codes fallback of 30 gets
used instead. This results in the broker waiting until it has processed very nearly every
message a producer could have sent with the outstanding credit before sending any new credit,
meaning producers with reasonable throughput will likely get stalled awaiting more credit
> The change in the coming PR corrects the XML config, changes the code to use the same
values as this for a consistent default, and adds a test to verify the default credit refresh
behaviour is as expected.

This message was sent by Atlassian JIRA

View raw message