activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Justin Bertram (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARTEMIS-1834) Incorrect STOMP destination header
Date Tue, 08 May 2018 20:35:00 GMT

    [ https://issues.apache.org/jira/browse/ARTEMIS-1834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467940#comment-16467940
] 

Justin Bertram commented on ARTEMIS-1834:
-----------------------------------------

GitHub user jbertram opened a pull request:

[https://github.com/apache/activemq-artemis/pull/2077]

ARTEMIS-1834 don't alter STOMP 'destination' header when using prefix

This is a regression caused by the fix for ARTEMIS-1794.

You can merge this pull request into a Git repository by running:

$ git pull [https://github.com/jbertram/activemq-artemis] ARTEMIS-1834

Alternatively you can review and apply these changes as the patch at:

[https://github.com/apache/activemq-artemis/pull/2077.patch]

To close this pull request, make a commit to your master/trunk branch
 with (at least) the following in the commit message:

This closes #2077
----
commit 3362741c77c63bba268b1d13648fc7630e29baa1
 Author: Justin Bertram <jbertram@...>
 Date: 2018-05-08T20:24:10Z

ARTEMIS-1834 don't alter STOMP 'destination' header when using prefix
----

> Incorrect STOMP destination header
> ----------------------------------
>
>                 Key: ARTEMIS-1834
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1834
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>            Reporter: Lionel Cons
>            Assignee: Justin Bertram
>            Priority: Major
>
> In the most recent snapshot (2.6.0-20180427.020303-62) the STOMP {{destination}} header
is now modified by Artemis.
> I'm using {{anycastPrefix=/queue/}} and {{multicastPrefix=/topic/}} to match ActiveMQ
5's STOMP behavior.
> When sending a message to {{/topic/foo}}, the sent STOMP frame contains {{destination:/topic/foo}}
in its header, as expected.
> However, the received STOMP frame now contains {{destination:foo}} in its header. It
was {{destination:/topic/foo}} in previous Artemis versions.
> IMHO, the STOMP {{destination}} header should be left untouched. {{anycastPrefix}} and
{{multicastPrefix}} should only be used to guess the destination type and not to change the
destination string itself.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message