activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARTEMIS-1804) NPE in recent snapshot
Date Fri, 04 May 2018 12:22:00 GMT

    [ https://issues.apache.org/jira/browse/ARTEMIS-1804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16463801#comment-16463801
] 

ASF GitHub Bot commented on ARTEMIS-1804:
-----------------------------------------

GitHub user jdanekrh opened a pull request:

    https://github.com/apache/activemq-artemis/pull/2071

    ARTEMIS-1804 don't call deprecated SslHandler#close() to avoid NPE in Netty

    The stacktrace of the exception involves a deprecated method. For some reason, using the
recommended alternative does not produce the exception... Could this PR be step in the right
direction?
    
    The Netty exception appears when OpenWire client which is using SSL disconnects:
    
    2018-05-04 09:56:44,424 WARN  [io.netty.handler.ssl.SslHandler] [id: 0x1dcd30fa, L:/127.0.0.1:61617
! R:/127.0.0.1:33006] flush() raised a masked exception.: java.lang.NullPointerException
            at io.netty.handler.ssl.SslHandler.wrapAndFlush(SslHandler.java:760) [netty-all-4.1.24.Final.jar:4.1.24.Final]
            at io.netty.handler.ssl.SslHandler.flush(SslHandler.java:752) [netty-all-4.1.24.Final.jar:4.1.24.Final]
            at io.netty.handler.ssl.SslHandler.flush(SslHandler.java:1625) [netty-all-4.1.24.Final.jar:4.1.24.Final]
            at io.netty.handler.ssl.SslHandler.access$600(SslHandler.java:165) [netty-all-4.1.24.Final.jar:4.1.24.Final]
            at io.netty.handler.ssl.SslHandler$1.run(SslHandler.java:649) [netty-all-4.1.24.Final.jar:4.1.24.Final]
            at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:163)
[netty-all-4.1.24.Final.jar:4.1.24.Final]
            at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:404)
[netty-all-4.1.24.Final.jar:4.1.24.Final]
            at io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:309) [netty-all-4.1.24.Final.jar:4.1.24.Final]
            at io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:884)
[netty-all-4.1.24.Final.jar:4.1.24.Final]
            at org.apache.activemq.artemis.utils.ActiveMQThreadFactory$1.run(ActiveMQThreadFactory.java:118)
[artemis-commons-2.6.0-SNAPSHOT.jar:2.6.0-SNAPSHOT]

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jdanekrh/activemq-artemis jd_netty_flush_woodo

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/2071.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2071
    
----
commit b38a424a34fe0a6d3cef220e13bc906164b99e8c
Author: Jiri Danek <jdanek@...>
Date:   2018-05-04T12:15:43Z

    ARTEMIS-1804 don't call deprecated SslHandler#close() to avoid NPE in Netty
    
    The Netty exception appears when OpenWire client which is using SSL disconnects:
    
    2018-05-04 09:56:44,424 WARN  [io.netty.handler.ssl.SslHandler] [id: 0x1dcd30fa, L:/127.0.0.1:61617
! R:/127.0.0.1:33006] flush() raised a masked exception.: java.lang.NullPointerException
            at io.netty.handler.ssl.SslHandler.wrapAndFlush(SslHandler.java:760) [netty-all-4.1.24.Final.jar:4.1.24.Final]
            at io.netty.handler.ssl.SslHandler.flush(SslHandler.java:752) [netty-all-4.1.24.Final.jar:4.1.24.Final]
            at io.netty.handler.ssl.SslHandler.flush(SslHandler.java:1625) [netty-all-4.1.24.Final.jar:4.1.24.Final]
            at io.netty.handler.ssl.SslHandler.access$600(SslHandler.java:165) [netty-all-4.1.24.Final.jar:4.1.24.Final]
            at io.netty.handler.ssl.SslHandler$1.run(SslHandler.java:649) [netty-all-4.1.24.Final.jar:4.1.24.Final]
            at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:163)
[netty-all-4.1.24.Final.jar:4.1.24.Final]
            at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:404)
[netty-all-4.1.24.Final.jar:4.1.24.Final]
            at io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:309) [netty-all-4.1.24.Final.jar:4.1.24.Final]
            at io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:884)
[netty-all-4.1.24.Final.jar:4.1.24.Final]
            at org.apache.activemq.artemis.utils.ActiveMQThreadFactory$1.run(ActiveMQThreadFactory.java:118)
[artemis-commons-2.6.0-SNAPSHOT.jar:2.6.0-SNAPSHOT]

----


> NPE in recent snapshot
> ----------------------
>
>                 Key: ARTEMIS-1804
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1804
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>            Reporter: Lionel Cons
>            Priority: Major
>
> Running some tests againstĀ {{artemis-2.6.0-20180410.175207-36}}, I noticed the broker
logged several NPEs looking like:
> {code:java}
> 2018-04-12 14:19:15,097 WARN  [io.netty.handler.ssl.SslHandler] [id: 0xc8c4c74d, L:/xxx:yyy
! R:/aaa:bbb] flush() raised a masked exception.: java.lang.NullPointerException
> 	at io.netty.handler.ssl.SslHandler.wrapAndFlush(SslHandler.java:742) [netty-all-4.1.22.Final.jar:4.1.22.Final]
> 	at io.netty.handler.ssl.SslHandler.flush(SslHandler.java:734) [netty-all-4.1.22.Final.jar:4.1.22.Final]
> 	at io.netty.handler.ssl.SslHandler.flush(SslHandler.java:1595) [netty-all-4.1.22.Final.jar:4.1.22.Final]
> 	at io.netty.handler.ssl.SslHandler.access$600(SslHandler.java:165) [netty-all-4.1.22.Final.jar:4.1.22.Final]
> 	at io.netty.handler.ssl.SslHandler$1.run(SslHandler.java:631) [netty-all-4.1.22.Final.jar:4.1.22.Final]
> 	at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:163)
[netty-all-4.1.22.Final.jar:4.1.22.Final]
> 	at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:404)
[netty-all-4.1.22.Final.jar:4.1.22.Final]
> 	at io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:309) [netty-all-4.1.22.Final.jar:4.1.22.Final]
> 	at io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:886)
[netty-all-4.1.22.Final.jar:4.1.22.Final]
> 	at org.apache.activemq.artemis.utils.ActiveMQThreadFactory$1.run(ActiveMQThreadFactory.java:118)
[artemis-commons-2.6.0-SNAPSHOT.jar:2.6.0-SNAPSHOT]
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message