From issues-return-27625-archive-asf-public=cust-asf.ponee.io@activemq.apache.org Wed Apr 18 18:36:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id B55CF180789 for ; Wed, 18 Apr 2018 18:36:04 +0200 (CEST) Received: (qmail 40265 invoked by uid 500); 18 Apr 2018 16:36:03 -0000 Mailing-List: contact issues-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list issues@activemq.apache.org Received: (qmail 40252 invoked by uid 99); 18 Apr 2018 16:36:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Apr 2018 16:36:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 337D81A1A77 for ; Wed, 18 Apr 2018 16:36:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -101.511 X-Spam-Level: X-Spam-Status: No, score=-101.511 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 7X5mJC6PSHnH for ; Wed, 18 Apr 2018 16:36:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 26F285FBF7 for ; Wed, 18 Apr 2018 16:36:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 3AB2EE0CBC for ; Wed, 18 Apr 2018 16:36:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 5982F241CF for ; Wed, 18 Apr 2018 16:36:00 +0000 (UTC) Date: Wed, 18 Apr 2018 16:36:00 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: issues@activemq.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (AMQ-6947) Queue pending message count can go negative on duplicates MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/AMQ-6947?page=3Dcom.atlassian.j= ira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D164428= 10#comment-16442810 ]=20 ASF subversion and git services commented on AMQ-6947: ------------------------------------------------------ Commit 79fae8c00ba60c46b913c6b39370b20c6d15e6ac in activemq's branch refs/h= eads/activemq-5.15.x from [~cshannon] [ https://git-wip-us.apache.org/repos/asf?p=3Dactivemq.git;h=3D79fae8c ] Revert "AMQ-6947 - Make sure counters are updated correct on message drop" This reverts commit 1fe096cb2a3ec03dbf5a7aab05c0960f8c739339. > Queue pending message count can go negative on duplicates > --------------------------------------------------------- > > Key: AMQ-6947 > URL: https://issues.apache.org/jira/browse/AMQ-6947 > Project: ActiveMQ > Issue Type: Bug > Components: Broker > Affects Versions: 5.15.3 > Reporter: Christopher L. Shannon > Priority: Minor > Fix For: 5.16.0, 5.15.4 > > > I have a found an edge case where the destination statistics counter on a= Queue can go negative if there are duplicate messages (which should be rar= e).=C2=A0=C2=A0The issue is the statistic is decremented but should not be = because the message was already dropped since there was a duplicate.=C2=A0 = Also, another statistic is improperly incremented which is the dequeue coun= ter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)