From issues-return-27389-archive-asf-public=cust-asf.ponee.io@activemq.apache.org Thu Apr 12 16:05:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 282DB18077F for ; Thu, 12 Apr 2018 16:05:04 +0200 (CEST) Received: (qmail 94963 invoked by uid 500); 12 Apr 2018 14:05:04 -0000 Mailing-List: contact issues-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list issues@activemq.apache.org Received: (qmail 94954 invoked by uid 99); 12 Apr 2018 14:05:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 Apr 2018 14:05:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id AA312180675 for ; Thu, 12 Apr 2018 14:05:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id HLIzLsXUpfxt for ; Thu, 12 Apr 2018 14:05:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 130A95FB2E for ; Thu, 12 Apr 2018 14:05:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 5454BE0117 for ; Thu, 12 Apr 2018 14:05:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1E4D021209 for ; Thu, 12 Apr 2018 14:05:00 +0000 (UTC) Date: Thu, 12 Apr 2018 14:05:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@activemq.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ARTEMIS-1803) MessageReference should include sessionId MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ARTEMIS-1803?page=3Dcom.atlassi= an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16= 435626#comment-16435626 ]=20 ASF GitHub Bot commented on ARTEMIS-1803: ----------------------------------------- Github user cshannon commented on the issue: https://github.com/apache/activemq-artemis/pull/2012 =20 @michaelandrepearce - because 1) there can be more than just that use = case for having sessionId part of the reference in the future and 2) the ac= knowledge code is not part of the consumer and is handled later by the Queu= eImpl...see the acknowledge method inside QueueImpl..it just gets the refer= ence and does the acking and doesn't know the consumer by that point becaus= e the ServerConsumer calls ack on the ref but doesn't pass itself to it...t= here would have to be a good amount of refactoring to change this along wit= h changes to public interfaces > MessageReference should include sessionId > ----------------------------------------- > > Key: ARTEMIS-1803 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1803 > Project: ActiveMQ Artemis > Issue Type: Improvement > Affects Versions: 2.5.0 > Reporter: Christopher L. Shannon > Assignee: Christopher L. Shannon > Priority: Minor > > Right now a MessageReference will track a consumerId (in certain scenario= s) but the sessionId is not included.=C2=A0 This is a problem because consu= merIds are not unique and are duplicated across sessions.=C2=A0 In order to= find a unique consumer you need the sessionId and consumerId as well.=C2= =A0 > A=C2=A0use case for when this is important is=C2=A0when writing custom pl= ugins.=C2=A0 Some of the callbacks pass a message reference=C2=A0and it wou= ld be good to be able to figure out which consumer the reference belonged t= o such as in the messageAcknowledged callback. -- This message was sent by Atlassian JIRA (v7.6.3#76005)