activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARTEMIS-1825) Live-backup topology not correctly displayed on console
Date Thu, 26 Apr 2018 03:02:00 GMT

    [ https://issues.apache.org/jira/browse/ARTEMIS-1825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453413#comment-16453413
] 

ASF GitHub Bot commented on ARTEMIS-1825:
-----------------------------------------

Github user gaohoward commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2041#discussion_r184259404
  
    --- Diff: artemis-hawtio/artemis-plugin/src/main/webapp/plugin/js/brokerDiagram.js ---
    @@ -455,16 +457,27 @@ var ARTEMIS = (function(ARTEMIS) {
                                   addLinkIds("broker:" + broker.brokerId, "broker:" + "\""
+ remoteBroker.live + "\"", "network");
     
                                   var backup = remoteBroker.backup;
    +                              ARTEMIS.log.info("isbackup? " + backup);
                                   if (backup) {
                                      getOrAddBroker(false, "\"" + backup + "\"", remoteBroker.nodeID,
"remote", null, properties);
                                      addLinkIds("broker:" + "\"" + remoteBroker.live + "\"",
"broker:" + "\"" + backup + "\"", "network");
                                   }
                                }
                                else {
    -                              var backup = remoteBroker.backup;
    -                              if (backup) {
    -                                 getOrAddBroker(false, "\"" + remoteBroker.backup + "\"",
remoteBroker.nodeID, "remote", null, properties);
    -                                 addLinkIds("broker:" + broker.brokerId, "broker:" +
"\"" + remoteBroker.backup + "\"", "network");
    +                              var newBackReq = ARTEMISService.artemisConsole.isBackup(jolokia,
mBean);
    +                              var newBackup = newBackReq.value;
    +                              if (!newBackup) {
    +                                 ARTEMIS.log.info("yes I'm master right now");
    +                                 if (remoteBroker.backup) {
    +                                    getOrAddBroker(false, "\"" + remoteBroker.backup
+ "\"", remoteBroker.nodeID, "remote", null, properties);
    +                                    addLinkIds("broker:" + broker.brokerId, "broker:"
+ "\"" + remoteBroker.backup + "\"", "network");
    +                                 }
    +                              }
    +                              else {
    +                                 ARTEMIS.log.info("ok I'm backup!");
    --- End diff --
    
    Yes should be debug. I'll change that. Thx.


> Live-backup topology not correctly displayed on console
> -------------------------------------------------------
>
>                 Key: ARTEMIS-1825
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1825
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: Web Console
>    Affects Versions: 2.5.0
>            Reporter: Howard Gao
>            Assignee: Howard Gao
>            Priority: Major
>             Fix For: 2.5.1
>
>
> The backup's web console doesn't correctly shows the topology diagram of live-backup
pair. It points to itself.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message