activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "clebert suconic (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (ARTEMIS-1822) Inconsistent method name
Date Fri, 27 Apr 2018 01:25:00 GMT

     [ https://issues.apache.org/jira/browse/ARTEMIS-1822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

clebert suconic updated ARTEMIS-1822:
-------------------------------------
       Priority: Trivial  (was: Major)
    Component/s: Broker
     Issue Type: Task  (was: Improvement)

> Inconsistent method name
> ------------------------
>
>                 Key: ARTEMIS-1822
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1822
>             Project: ActiveMQ Artemis
>          Issue Type: Task
>          Components: Broker
>            Reporter: KuiLIU
>            Priority: Trivial
>
> The following method is named "lookupRecord".
> "lookupRecord" seems to find a related record.
> But the method is checking whether recordsSnapshot contains the id or not.
> Thus, the method name "containsRecord" is more intuitive than "lookupRecord".
> {code:java}
>    public boolean lookupRecord(final long id) {
>       return recordsSnapshot.contains(id);
>    }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message