activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARTEMIS-1819) Missing fields on listAllConsumersAsJSON, listConsumersAsJSON and listConnectionsAsJSON
Date Sat, 21 Apr 2018 00:46:01 GMT

    [ https://issues.apache.org/jira/browse/ARTEMIS-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16446543#comment-16446543
] 

ASF GitHub Bot commented on ARTEMIS-1819:
-----------------------------------------

Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2035#discussion_r183194331
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/ActiveMQServerControlImpl.java
---
    @@ -1873,7 +1886,9 @@ public String listAllSessionsAsJSON() throws Exception {
           try {
              Set<ServerSession> sessions = server.getSessions();
              for (ServerSession sess : sessions) {
    -            JsonObjectBuilder obj = JsonLoader.createObjectBuilder().add("sessionID",
sess.getName()).add("creationTime", sess.getCreationTime()).add("consumerCount", sess.getServerConsumers().size());
    +            JsonObjectBuilder obj = JsonLoader.createObjectBuilder().add("sessionID",
sess.getName())
    +               .add("creationTime", sess.getCreationTime())
    --- End diff --
    
    Please avoid reformatting like this, there's no code change here 


> Missing fields on listAllConsumersAsJSON, listConsumersAsJSON and listConnectionsAsJSON
> ---------------------------------------------------------------------------------------
>
>                 Key: ARTEMIS-1819
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1819
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 2.5.0
>            Reporter: Ingo Weiss
>            Priority: Minor
>              Labels: regresion
>
> This is a regression against 1.5.5. Some fields are missing. On 
> listConsumersAsJSON and listAllConsumersAsJSON the fields are destinationName, destinationType
and durable. listConnectionsAsJSON is missing clientID.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message