activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARTEMIS-1816) OpenWire should avoid ByteArrayOutputStream lazy allocation
Date Thu, 19 Apr 2018 18:07:00 GMT

    [ https://issues.apache.org/jira/browse/ARTEMIS-1816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16444498#comment-16444498
] 

ASF GitHub Bot commented on ARTEMIS-1816:
-----------------------------------------

Github user franz1981 commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2031
  
    I agree but given the short window until a new release i have preferred to push this (that's
quite stable and safe) and taking my time to improve the other optimal way. That pr currently
broke (last time I have checked) too many tests and I think it worth to make it stable without
rushing.



> OpenWire should avoid ByteArrayOutputStream lazy allocation
> -----------------------------------------------------------
>
>                 Key: ARTEMIS-1816
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1816
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>          Components: Broker, OpenWire
>    Affects Versions: 2.5.0
>            Reporter: Francesco Nigro
>            Assignee: Francesco Nigro
>            Priority: Minor
>
> OpenWireMessageConverter::toAMQMessage on bytes messages is lazy allocating a write buffer
with a default size of 1024 even when it won't be used to write anything.
> To avoid an useless allocation would be better to reduce it to a zero length one.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message