activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARTEMIS-1807) File-based Large Message encoding should use read-only mmap
Date Mon, 16 Apr 2018 15:43:00 GMT

    [ https://issues.apache.org/jira/browse/ARTEMIS-1807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16439601#comment-16439601
] 

ASF GitHub Bot commented on ARTEMIS-1807:
-----------------------------------------

Github user franz1981 commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2015
  
    @gaohoward 
    
    > I think using mapped file will get better performance over the NIO channel read.
    
    @orpiske have some nice idea to test it for sure :P
    
    > It would be better to have a unit test with it. @clebertsuconic wdyt?
    
    @clebertsuconic @gaohoward 
    If you 2 will vote for the chunked version I will squash the 2 commits and provide a unit
test to cover this new implementation: ATM it is just using the tests related to large messages.
    
    @clebertsuconic 
    > I think so too.. but I would do it in the context of a refactoring in AMQP also
    
    That means that the same large body encoder should be reused for it as well?
    



> File-based Large Message encoding should use read-only mmap
> -----------------------------------------------------------
>
>                 Key: ARTEMIS-1807
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1807
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>          Components: Broker
>    Affects Versions: 2.5.0
>            Reporter: Francesco Nigro
>            Assignee: Francesco Nigro
>            Priority: Major
>
> File-based LargeServerMessageImpl should use read-only memory mapping while reading the
file, in order to:
>  * reduce the number of copiesĀ 
>  * reduce the context switches



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message