activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARTEMIS-1790) Improve Topology Member Finding
Date Tue, 10 Apr 2018 17:37:00 GMT

    [ https://issues.apache.org/jira/browse/ARTEMIS-1790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16432636#comment-16432636
] 

ASF GitHub Bot commented on ARTEMIS-1790:
-----------------------------------------

Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1999
  
    only issue I see is.. if this is broken.. then Topology::getMember(TransportConfiguration)
is probably broken as well? That's used on freezeConnections and ScaleDownHandler
    
    any chance you can fix it?


> Improve Topology Member Finding
> -------------------------------
>
>                 Key: ARTEMIS-1790
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1790
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>          Components: Broker
>    Affects Versions: 2.5.0
>            Reporter: Howard Gao
>            Assignee: Howard Gao
>            Priority: Major
>             Fix For: 2.5.1
>
>
> When finding out if a connector belong to a target node it compares the whole parameter
map which is not necessary. Also in understanding the connector the best place is to delegate
it to the corresponding remoting connection who understands it. (e.g. INVMConnection knows
whether the connector belongs to a target node by checking it's serverID only. The netty ones
only need to match host and port, and understanding that localhost and 127.0.0.1 are same
thing).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message