From issues-return-26900-archive-asf-public=cust-asf.ponee.io@activemq.apache.org Tue Mar 27 11:41:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id E588218064E for ; Tue, 27 Mar 2018 11:41:04 +0200 (CEST) Received: (qmail 26438 invoked by uid 500); 27 Mar 2018 09:41:04 -0000 Mailing-List: contact issues-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list issues@activemq.apache.org Received: (qmail 26426 invoked by uid 99); 27 Mar 2018 09:41:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Mar 2018 09:41:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 9B4F9C0145 for ; Tue, 27 Mar 2018 09:41:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.311 X-Spam-Level: X-Spam-Status: No, score=-110.311 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 4oDo7HXjXdKk for ; Tue, 27 Mar 2018 09:41:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 4FF175FD54 for ; Tue, 27 Mar 2018 09:41:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 47284E0E55 for ; Tue, 27 Mar 2018 09:41:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id AF52D21515 for ; Tue, 27 Mar 2018 09:41:00 +0000 (UTC) Date: Tue, 27 Mar 2018 09:41:00 +0000 (UTC) From: "Max-Julian Pogner (JIRA)" To: issues@activemq.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (AMQ-6939) misleading error message in TcpTransportFactory.java MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/AMQ-6939?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:all-tabpanel ] Max-Julian Pogner updated AMQ-6939: ----------------------------------- Description:=20 A configuration error by the reporter of this issue could have been assiste= d better by a different error message and different website documentation. This issue proposed two changes: 1) Fix the Format-String in the error-message and also enhance the error me= ssage with the path (patch attached). Note: A related discussion / change was previously held here: AMQ-2256 2) amend the website documentation. as i am newbyly unsure how to produce a= patch for the website, i resort to a pseudo-patch manually written: =C2=A0 {code:java} File: http://activemq.apache.org/tcp-transport-reference.html In section "Configuration Syntax" Starting from first line in the section: - tcp://hostname:port?key=3Dvalue + tcp://=C2=ABhostname=C2=BB:=C2=ABport=C2=BB[/=C2=ABbindhostaddress=C2=BB:= =C2=ABbindhostport=C2=BB][?key1=3Dvalue1&key2=3Dvalue2] + + beside the mandatory hostname and port of the server, + the optional path specifies the local address and port to bind the tcp so= cket to. Note: the path containing only "/" is invalid (use empty string as= path instead), and + the optional query string sets one or more of the transport options below= .{code} I am unsure whether the =C2=ABport=C2=BB should be documented as optional o= r mandatory. was: A configuration error by the reporter of this issue could have been assiste= d better by a different error message and different website documentation. This issue proposed two changes: 1) Fix the Format-String in the error-message and also enhance the error me= ssage with the path (patch attached) 2) amend the website documentation. as i am newbyly unsure how to produce a= patch for the website, i resort to a pseudo-patch manually written: =C2=A0 {code:java} File: http://activemq.apache.org/tcp-transport-reference.html In section "Configuration Syntax" Starting from first line in the section: - tcp://hostname:port?key=3Dvalue + tcp://=C2=ABhostname=C2=BB:=C2=ABport=C2=BB[/=C2=ABbindhostaddress=C2=BB:= =C2=ABbindhostport=C2=BB][?key1=3Dvalue1&key2=3Dvalue2] + + beside the mandatory hostname and port of the server, + the optional path specifies the local address and port to bind the tcp so= cket to. Note: the path containing only "/" is invalid (use empty string as= path instead), and + the optional query string sets one or more of the transport options below= .{code} I am unsure whether the =C2=ABport=C2=BB should be documented as optional o= r mandatory. > misleading error message in TcpTransportFactory.java > ---------------------------------------------------- > > Key: AMQ-6939 > URL: https://issues.apache.org/jira/browse/AMQ-6939 > Project: ActiveMQ > Issue Type: Improvement > Components: JMS client > Affects Versions: 5.15.3 > Reporter: Max-Julian Pogner > Priority: Minor > Labels: newbie, pull-request-available > Attachments: 0001-TcpTransportFactory-fix-format-in-error-message= .patch > > > A configuration error by the reporter of this issue could have been assis= ted better by a different error message and different website documentation= . > This issue proposed two changes: > 1) Fix the Format-String in the error-message and also enhance the error = message with the path (patch attached). > Note: A related discussion / change was previously held here: AMQ-2256 > 2) amend the website documentation. as i am newbyly unsure how to produce= a patch for the website, i resort to a pseudo-patch manually written: > =C2=A0 > {code:java} > File: http://activemq.apache.org/tcp-transport-reference.html > In section "Configuration Syntax" > Starting from first line in the section: > - tcp://hostname:port?key=3Dvalue > + tcp://=C2=ABhostname=C2=BB:=C2=ABport=C2=BB[/=C2=ABbindhostaddress=C2= =BB:=C2=ABbindhostport=C2=BB][?key1=3Dvalue1&key2=3Dvalue2] > + > + beside the mandatory hostname and port of the server, > + the optional path specifies the local address and port to bind the tcp = socket to. Note: the path containing only "/" is invalid (use empty string = as path instead), and > + the optional query string sets one or more of the transport options bel= ow.{code} > I am unsure whether the =C2=ABport=C2=BB should be documented as optional= or mandatory. -- This message was sent by Atlassian JIRA (v7.6.3#76005)