From issues-return-25310-archive-asf-public=cust-asf.ponee.io@activemq.apache.org Thu Feb 1 09:40:11 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 1E20E180652 for ; Thu, 1 Feb 2018 09:40:11 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 0DC29160C44; Thu, 1 Feb 2018 08:40:11 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 309F1160C26 for ; Thu, 1 Feb 2018 09:40:10 +0100 (CET) Received: (qmail 21835 invoked by uid 500); 1 Feb 2018 08:40:08 -0000 Mailing-List: contact issues-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list issues@activemq.apache.org Received: (qmail 21826 invoked by uid 99); 1 Feb 2018 08:40:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Feb 2018 08:40:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 62AD1199736 for ; Thu, 1 Feb 2018 08:40:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id BTWQF7vIT0XS for ; Thu, 1 Feb 2018 08:40:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 4ACDE5FBF5 for ; Thu, 1 Feb 2018 08:40:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id CCE4CE02F7 for ; Thu, 1 Feb 2018 08:40:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 36A0E21E88 for ; Thu, 1 Feb 2018 08:40:00 +0000 (UTC) Date: Thu, 1 Feb 2018 08:40:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@activemq.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ARTEMIS-1498) [interop] Openwire internal headers should not be part of message properties MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ARTEMIS-1498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16348207#comment-16348207 ] ASF GitHub Bot commented on ARTEMIS-1498: ----------------------------------------- Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1793#discussion_r165287490 --- Diff: artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireConverter.java --- @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.activemq.artemis.core.protocol.openwire; + +import org.apache.activemq.artemis.api.core.ICoreMessage; +import org.apache.activemq.artemis.core.message.impl.CoreMessageObjectPools; +import org.apache.activemq.artemis.spi.core.protocol.MessageConverter; + +public class OpenWireConverter implements MessageConverter { + + private static final OpenWireConverter theInstance = new OpenWireConverter(); + private OpenWireConverter() { + } + + public static OpenWireConverter getInstance() { + return theInstance; + } + + @Override + public OpenwireMessage fromCore(ICoreMessage coreMessage) throws Exception { --- End diff -- seems one is left, i think the class was there before unused, would you mind? OpenwireMessage -> OpenWireMessage > [interop] Openwire internal headers should not be part of message properties > ---------------------------------------------------------------------------- > > Key: ARTEMIS-1498 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1498 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: OpenWire > Environment: interoperability between Openwire -> AMQP/Core > Reporter: Michal Toth > Priority: Minor > > Sending an empty message from Openwire JMS client to AMQP or Core receiver client shows extra "internal" headers (__HDR_*) in message properties. > They should not be there, as these are internal for broker in my opinion. > Openwire sender > {noformat} > $ java -jar /var/dtests/node_data/clients/aoc7.jar sender --timeout 5 --log-msgs interop --broker tcp://localhost:61616 --address queue_name_\$ --count 1 --conn-username admin --conn-password admin > {'durable': True, 'priority': 4, 'ttl': 0, 'first-acquirer': False, 'delivery-count': 0, 'id': 'dhcp-145-96.lab.eng.brq.redhat.com-33646-1509702974536-1:1:1:1:1', 'user-id':None, 'address': 'queue_name_$', 'subject': None, 'reply-to': None, 'correlation-id': None, 'content-type': None, 'content-encoding': None, 'absolute-expiry-time': 0, 'creation-time': 1509702974798, 'group-id': None, 'group-sequence': 0, 'reply-to-group-id': None, 'properties': {}, 'content': None, 'type': None} > {noformat} > AMQP/Core receiver > {noformat} > $ java -jar /var/dtests/node_data/clients/aac1.jar receiver --timeout 5 --log-msgs interop --broker localhost:5672 --address queue_name_\$ --count 1 --conn-username admin --conn-password admin > Unsupported object type org.apache.qpid.proton.amqp.Binary \x00\x00\x00Jn\x02\xae\x02{\x00=ID:dhcp-145-96.lab.eng.brq.redhat.com-33646-1509702974536-1:1\x00\x01\x00\x01\x00\x01 > Unsupported object type org.apache.qpid.proton.amqp.Binary \x00\x00\x00F{\x01+\x00=ID:dhcp-145-96.lab.eng.brq.redhat.com-33646-1509702974536-1:1\x00\x01\x00\x01 > {'durable': True, 'priority': 4, 'ttl': 0, 'first-acquirer': False, 'delivery-count': 0, 'id': None, 'user-id': None, 'address': 'queue_name_$', 'subject': None, 'reply-to': None, 'correlation-id': None, 'content-type': None, 'content-encoding': None, 'absolute-expiry-time': 0, 'creation-time': 1509702974798, 'group-id': None, 'group-sequence': 0, 'reply-to-group-id': None, 'properties': {'__HDR_COMMAND_ID': 5, 'JMSXDeliveryCount': 1, '__HDR_ARRIVAL': 0, '__HDR_MESSAGE_ID': \x00\x00\x00Jn\x02\xae\x02{\x00=ID:dhcp-145-96.lab.eng.brq.redhat.com-33646-1509702974536-1:1\x00\x01\x00\x01\x00\x01, '__HDR_GROUP_SEQUENCE': 0, '__HDR_PRODUCER_ID': \x00\x00\x00F{\x01+\x00=ID:dhcp-145-96.lab.eng.brq.redhat.com-33646-1509702974536-1:1\x00\x01\x00\x01, '__HDR_DROPPABLE': False, '__HDR_BROKER_IN_TIME': 1509702974800}, 'content': None} > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)