activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARTEMIS-1697) Simplify ActivateCallback interface with default methods
Date Thu, 22 Feb 2018 18:44:00 GMT

    [ https://issues.apache.org/jira/browse/ARTEMIS-1697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16373236#comment-16373236
] 

ASF GitHub Bot commented on ARTEMIS-1697:
-----------------------------------------

GitHub user jbertram opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1888

    ARTEMIS-1697 give ActivateCallback default methods

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1697

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1888.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1888
    
----
commit 56f7c523b720f345243bbd423cce9042af6c3ba4
Author: Justin Bertram <jbertram@...>
Date:   2018-02-22T18:42:18Z

    ARTEMIS-1697 give ActivateCallback default methods

----


> Simplify ActivateCallback interface with default methods
> --------------------------------------------------------
>
>                 Key: ARTEMIS-1697
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1697
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>            Reporter: Justin Bertram
>            Assignee: Justin Bertram
>            Priority: Major
>
> Most of the org.apache.activemq.artemis.core.server.ActivateCallback implementations
have empty methods.  By providing default method implementations on the interface (thanks
Java 8!) we can get rid of a lot of the useless code in the current implementations.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message