activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARTEMIS-1664) fix npe bug while getting element in the process of rehash
Date Tue, 06 Feb 2018 14:02:00 GMT

    [ https://issues.apache.org/jira/browse/ARTEMIS-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16353903#comment-16353903
] 

ASF GitHub Bot commented on ARTEMIS-1664:
-----------------------------------------

Github user franz1981 commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1851#discussion_r166307381
  
    --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/ConcurrentLongHashMap.java
---
    @@ -457,10 +457,10 @@ private void rehash() {
                 }
              }
     
    -         capacity = newCapacity;
              keys = newKeys;
              values = newValues;
              usedBuckets = size;
    +         capacity = newCapacity;
    --- End diff --
    
    Please check if is possible to use a lazySet too (maybe with an `AtomicFieldUpdater` or
similar) to write release the keys/values in order to avoid a full barrier


> fix npe bug while getting element in the process of rehash
> ----------------------------------------------------------
>
>                 Key: ARTEMIS-1664
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1664
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 2.4.0
>            Reporter: yangwei
>            Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message