activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARTEMIS-1663) Add enhanced message count and size metrics for Queues
Date Wed, 07 Feb 2018 12:25:00 GMT

    [ https://issues.apache.org/jira/browse/ARTEMIS-1663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16355376#comment-16355376
] 

ASF GitHub Bot commented on ARTEMIS-1663:
-----------------------------------------

Github user cshannon commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1853#discussion_r166601621
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/PageCountRecordInc.java
---
    @@ -26,17 +26,20 @@
     
        private int value;
     
    +   private long persistentSize;
    --- End diff --
    
    @michaelandrepearce  - That is fine I will make those values -1, but I don't think we
would try and re-calculate a correct value.  When loading the journal you'd have to re-load
the messages to calculate from the paging store which we don't want to do.  I think the proper
behavior is to just ignore it and not use the value in the calculations.  Then over time as
new records come in the values would be filled in and correct.  
    
    If I change the value to -1 on the record, are you thinking we should just have the getter
do the negative check and return 0 if it's -1 or were you thinking to just return -1 from
the getter and then check for negative everywhere else the value is used?
    



> Add enhanced message count and size metrics for Queues
> ------------------------------------------------------
>
>                 Key: ARTEMIS-1663
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1663
>             Project: ActiveMQ Artemis
>          Issue Type: New Feature
>          Components: Broker
>    Affects Versions: 2.4.0
>            Reporter: Christopher L. Shannon
>            Assignee: Christopher L. Shannon
>            Priority: Major
>
> The purpose of this Jira is to enhance the message count metrics and to add size metrics
for Queues.   By size metrics I mean the encoded size of all the messages (for large messages
this will include body as well).  Right now we track memory usage but it is also very useful
to know exactly how much data is pending on a Queue to be consumed.  
> The scope of this will be support for tracking the count/size of pending messages,
count/size of delivering messages, and count/size of scheduled messages.  For each of these
categories durable size metrics will be tracked as well. The paging store will also support
tracking of size metrics as well.
> These new metrics will be exposed through JMX to allow users to view the statistics. 
Also by tracking these new values it will allow for enhanced features in the future (ie new
flow control options)
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message