activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARTEMIS-1660) create-journal-table.oracle does create identity for column id
Date Fri, 16 Feb 2018 08:38:00 GMT

    [ https://issues.apache.org/jira/browse/ARTEMIS-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16366716#comment-16366716
] 

ASF GitHub Bot commented on ARTEMIS-1660:
-----------------------------------------

Github user franz1981 commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1866
  
    @graben 
    > Well, I'm actually not able to test against oracle 12 only have a oracle 11 express
instance
    
    It would be enough: it is just to validate the changes.
    
    > But it is obvious that the autoincrement of id is wrong, since it is 1st managed
by the broker and 2nd different to all other database types.
    
    Agree but would be anyway welcome at least a test round with the change.
    I will ping @mtaylor and @jmesnil authors of most the SQL contained there to validate
it: if they think that the change is safe as it seems, for me is ok :+1: 



> create-journal-table.oracle does create identity for column id
> --------------------------------------------------------------
>
>                 Key: ARTEMIS-1660
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1660
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>    Affects Versions: 2.4.0
>            Reporter: Benjamin Graf
>            Priority: Major
>
> Statement contains identity column for id. That's wrong according to generic create statement
and leaves invalid storage for userrecordtype 32/45



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message