activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARTEMIS-1649) enable openssl provider for Netty
Date Thu, 01 Feb 2018 09:59:00 GMT

    [ https://issues.apache.org/jira/browse/ARTEMIS-1649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16348319#comment-16348319
] 

ASF GitHub Bot commented on ARTEMIS-1649:
-----------------------------------------

Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1834#discussion_r165305348
  
    --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnector.java
---
    @@ -530,48 +539,34 @@ public synchronized void start() {
                    if (System.getProperty(ACTIVEMQ_TRUSTSTORE_PASSWORD_PROP_NAME) != null)
{
                       realTrustStorePassword = System.getProperty(ACTIVEMQ_TRUSTSTORE_PASSWORD_PROP_NAME);
                    }
    -               context = SSLSupport.createContext(realKeyStoreProvider, realKeyStorePath,
realKeyStorePassword, realTrustStoreProvider, realTrustStorePath, realTrustStorePassword,
trustAll, crlPath);
    +
                 }
              } catch (Exception e) {
                 close();
                 IllegalStateException ise = new IllegalStateException("Unable to create NettyConnector
for " + host + ":" + port);
                 ise.initCause(e);
                 throw ise;
              }
    -      } else {
    -         context = null; // Unused
           }
     
    -      if (context != null && useServlet) {
    -         // TODO: Fix me
    -         //bootstrap.setOption("sslContext", context);
    -      }
    +      //if (context != null && useServlet) {
    +      // TODO: Fix me
    +      //bootstrap.setOption("sslContext", context);
    +      //}
     
           bootstrap.handler(new ChannelInitializer<Channel>() {
    --- End diff --
    
    this probably could be made a lamda.


> enable openssl provider for Netty
> ---------------------------------
>
>                 Key: ARTEMIS-1649
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1649
>             Project: ActiveMQ Artemis
>          Issue Type: New Feature
>            Reporter: Rico Pahlisch
>            Priority: Major
>
> We want to use the native Openssl Provider for netty to use the native openssl.
> Added the supprt to switch between JDK and OpenSSL Provider.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message