From issues-return-24702-archive-asf-public=cust-asf.ponee.io@activemq.apache.org Thu Jan 18 17:13:05 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id C28D1180654 for ; Thu, 18 Jan 2018 17:13:05 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id B2B36160C48; Thu, 18 Jan 2018 16:13:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 0EAF7160C2B for ; Thu, 18 Jan 2018 17:13:04 +0100 (CET) Received: (qmail 62528 invoked by uid 500); 18 Jan 2018 16:13:04 -0000 Mailing-List: contact issues-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list issues@activemq.apache.org Received: (qmail 62515 invoked by uid 99); 18 Jan 2018 16:13:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 18 Jan 2018 16:13:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id A763D1A0532 for ; Thu, 18 Jan 2018 16:13:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.91 X-Spam-Level: X-Spam-Status: No, score=-99.91 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, URIBL_BLOCKED=0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id s5fWA9Xs_ry5 for ; Thu, 18 Jan 2018 16:13:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 568285F3E1 for ; Thu, 18 Jan 2018 16:13:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B424EE0161 for ; Thu, 18 Jan 2018 16:13:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 77DDA21304 for ; Thu, 18 Jan 2018 16:13:00 +0000 (UTC) Date: Thu, 18 Jan 2018 16:13:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@activemq.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ARTEMIS-1619) Add plugin support for address creation, update and removal MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 Auto-Submitted: auto-generated [ https://issues.apache.org/jira/browse/ARTEMIS-1619?page=3Dcom.atlassi= an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16= 330697#comment-16330697 ]=20 ASF GitHub Bot commented on ARTEMIS-1619: ----------------------------------------- Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1789#discussion_r162390= 192 =20 --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/art= emis/tests/integration/plugin/StompPluginTest.java --- @@ -127,10 +131,33 @@ public void testSendAndReceive() throws Exception= { AFTER_CREATE_SESSION, B= EFORE_CLOSE_SESSION, AFTER_CLOSE_SESSION, BEFORE_CREATE_CONSUMER, AFTER_CREATE_CONSUMER, = BEFORE_CLOSE_CONSUMER, AFTER_CLOSE_CONSUMER, BEFORE_CREATE_QUEUE, AFTER_CRE= ATE_QUEUE, MESSAGE_ACKED, BEFORE_S= END, AFTER_SEND, BEFORE_MESSAGE_ROUTE, AFTER_MESSAGE_ROUTE, BEFORE_DELIVER, - AFTER_DELIVER); + AFTER_DELIVER, BEFORE_A= DD_ADDRESS, AFTER_ADD_ADDRESS); + + } catch (Throwable e) { + fail(e.getMessage()); + } + + } + + @Test + public void testStompAutoCreateAddress() throws Exception { + + try { + URI uri =3D new URI("ws+v12.stomp://localhost:61613"); + StompClientConnection newConn =3D StompClientConnectionFactor= y.createClientConnection(uri); + newConn.connect(defUser, defPass); + + subscribeQueue(newConn, "a-sub", "autoCreated"); + + // unsub + unsubscribe(newConn, "a-sub"); + newConn.disconnect(); + + verifier.validatePluginMethodsAtLeast(1, BEFORE_ADD_ADDRESS, = AFTER_ADD_ADDRESS, + BEFORE_REMOVE_ADDRESS, AFTER_REMOVE_ADDRESS); =20 } catch (Throwable e) { - e.printStackTrace(); + fail(e.getMessage()); --- End diff -- =20 the printStackTrace is useful when it fails :) I have been there. > Add plugin support for address creation, update and removal > ----------------------------------------------------------- > > Key: ARTEMIS-1619 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1619 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker > Affects Versions: 2.4.0 > Reporter: Christopher L. Shannon > Assignee: Christopher L. Shannon > Priority: Major > Fix For: 2.5.0 > > > As I have been working on my own custom plugins I have found it would be = helpful to also have callbacks for when addresses are added, updated, or re= moved from the broker.=C2=A0 Addresses can be auto created and auto destroy= ed so being able to take some action on those events with the plugin API is= useful. -- This message was sent by Atlassian JIRA (v7.6.3#76005)