From issues-return-24617-archive-asf-public=cust-asf.ponee.io@activemq.apache.org Wed Jan 17 20:20:06 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 5953218062C for ; Wed, 17 Jan 2018 20:20:06 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 49206160C48; Wed, 17 Jan 2018 19:20:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 9404B160C35 for ; Wed, 17 Jan 2018 20:20:05 +0100 (CET) Received: (qmail 554 invoked by uid 500); 17 Jan 2018 19:20:04 -0000 Mailing-List: contact issues-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list issues@activemq.apache.org Received: (qmail 514 invoked by uid 99); 17 Jan 2018 19:20:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 17 Jan 2018 19:20:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 5AFC81A4333 for ; Wed, 17 Jan 2018 19:20:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.911 X-Spam-Level: X-Spam-Status: No, score=-99.911 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id NEghct4BZOZy for ; Wed, 17 Jan 2018 19:20:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 1C99A5F369 for ; Wed, 17 Jan 2018 19:20:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 46362E002F for ; Wed, 17 Jan 2018 19:20:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id F206B212FD for ; Wed, 17 Jan 2018 19:20:00 +0000 (UTC) Date: Wed, 17 Jan 2018 19:20:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@activemq.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ARTEMIS-1600) Support masked passwords in bootstrap.xm and login.config MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ARTEMIS-1600?page=3Dcom.atlassi= an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16= 329247#comment-16329247 ]=20 ASF GitHub Bot commented on ARTEMIS-1600: ----------------------------------------- Github user jbertram commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1771#discussion_r162151= 931 =20 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/spi/= core/security/jaas/LDAPLoginModule.java --- @@ -105,12 +110,39 @@ public void initialize(Subject subject, this.subject =3D subject; this.handler =3D callbackHandler; =20 - config =3D new LDAPLoginProperty[]{new LDAPLoginProperty(INITIAL= _CONTEXT_FACTORY, (String) options.get(INITIAL_CONTEXT_FACTORY)), new LDAPL= oginProperty(CONNECTION_URL, (String) options.get(CONNECTION_URL)), new LDA= PLoginProperty(CONNECTION_USERNAME, (String) options.get(CONNECTION_USERNAM= E)), new LDAPLoginProperty(CONNECTION_PASSWORD, (String) options.get(CONNEC= TION_PASSWORD)), new LDAPLoginProperty(CONNECTION_PROTOCOL, (String) option= s.get(CONNECTION_PROTOCOL)), new LDAPLoginProperty(AUTHENTICATION, (String)= options.get(AUTHENTICATION)), new LDAPLoginProperty(USER_BASE, (String) op= tions.get(USER_BASE)), new LDAPLoginProperty(USER_SEARCH_MATCHING, (String)= options.get(USER_SEARCH_MATCHING)), new LDAPLoginProperty(USER_SEARCH_SUBT= REE, (String) options.get(USER_SEARCH_SUBTREE)), new LDAPLoginProperty(ROLE= _BASE, (String) options.get(ROLE_BASE)), new LDAPLoginProperty(ROLE_NAME, (= String) options.get(ROLE_NAME)), new LDAPLoginProperty(ROLE_SEARCH_MATCHING= , (String) options.get(ROLE_SEARCH_MATCHING)), new LDAPLoginProperty(ROLE_S= EARCH_SUBTREE, (String) options.get(ROLE_SEARCH_SUBTREE)), new LDAPLoginPro= perty(USER_ROLE_NAME, (String) options.get(USER_ROLE_NAME)), new LDAPLoginP= roperty(EXPAND_ROLES, (String) options.get(EXPAND_ROLES)), new LDAPLoginPro= perty(EXPAND_ROLES_MATCHING, (String) options.get(EXPAND_ROLES_MATCHING)), = new LDAPLoginProperty(REFERRAL, (String) options.get(REFERRAL))}; + config =3D new LDAPLoginProperty[]{new LDAPLoginProperty(INITIAL= _CONTEXT_FACTORY, (String) options.get(INITIAL_CONTEXT_FACTORY)), + new LDAPLoginProperty(CONNECTIO= N_URL, (String) options.get(CONNECTION_URL)), + new LDAPLoginProperty(CONNECTIO= N_USERNAME, (String) options.get(CONNECTION_USERNAME)), + new LDAPLoginProperty(CONNECTIO= N_PASSWORD, (String) options.get(CONNECTION_PASSWORD)), + new LDAPLoginProperty(CONNECTIO= N_PROTOCOL, (String) options.get(CONNECTION_PROTOCOL)), + new LDAPLoginProperty(AUTHENTIC= ATION, (String) options.get(AUTHENTICATION)), + new LDAPLoginProperty(USER_BASE= , (String) options.get(USER_BASE)), + new LDAPLoginProperty(USER_SEAR= CH_MATCHING, (String) options.get(USER_SEARCH_MATCHING)), + new LDAPLoginProperty(USER_SEAR= CH_SUBTREE, (String) options.get(USER_SEARCH_SUBTREE)), + new LDAPLoginProperty(ROLE_BASE= , (String) options.get(ROLE_BASE)), + new LDAPLoginProperty(ROLE_NAME= , (String) options.get(ROLE_NAME)), + new LDAPLoginProperty(ROLE_SEAR= CH_MATCHING, (String) options.get(ROLE_SEARCH_MATCHING)), + new LDAPLoginProperty(ROLE_SEAR= CH_SUBTREE, (String) options.get(ROLE_SEARCH_SUBTREE)), + new LDAPLoginProperty(USER_ROLE= _NAME, (String) options.get(USER_ROLE_NAME)), + new LDAPLoginProperty(EXPAND_RO= LES, (String) options.get(EXPAND_ROLES)), + new LDAPLoginProperty(EXPAND_RO= LES_MATCHING, (String) options.get(EXPAND_ROLES_MATCHING)), + new LDAPLoginProperty(REFERRAL,= (String) options.get(REFERRAL))}; + if (isLoginPropertySet(AUTHENTICATE_USER)) { authenticateUser =3D Boolean.valueOf(getLDAPPropertyValue(AUT= HENTICATE_USER)); } isRoleAttributeSet =3D isLoginPropertySet(ROLE_NAME); roleAttributeName =3D getLDAPPropertyValue(ROLE_NAME); + String isMask =3D (String) options.get(MASK_PASSWORD); --- End diff -- =20 This isn't used anywhere so it can be removed. > Support masked passwords in bootstrap.xm and login.config > --------------------------------------------------------- > > Key: ARTEMIS-1600 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1600 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker, Web Console > Affects Versions: 2.4.0 > Reporter: Howard Gao > Assignee: Howard Gao > Priority: Major > Fix For: 2.5.0 > > > We provide a feature to mask passwords in the configuration files.=20 > However, passwords in the bootstrap.xml (when the console is=20 > secured with HTTPS) cannot be masked. This enhancement has=20 > been opened to allow passwords in the bootstrap.xml to be masked > using the built-in masking feature provided by the broker. > Also the LDAPLoginModule configuration (in login.config) has a=20 > connection password attribute that also needs this mask support. -- This message was sent by Atlassian JIRA (v7.6.3#76005)