From issues-return-24334-archive-asf-public=cust-asf.ponee.io@activemq.apache.org Wed Jan 10 16:31:06 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 8280618076D for ; Wed, 10 Jan 2018 16:31:06 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 72C2B160C23; Wed, 10 Jan 2018 15:31:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id C1E0C160C2E for ; Wed, 10 Jan 2018 16:31:05 +0100 (CET) Received: (qmail 53547 invoked by uid 500); 10 Jan 2018 15:31:05 -0000 Mailing-List: contact issues-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list issues@activemq.apache.org Received: (qmail 53537 invoked by uid 99); 10 Jan 2018 15:31:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Jan 2018 15:31:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 701D818062E for ; Wed, 10 Jan 2018 15:31:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -107.911 X-Spam-Level: X-Spam-Status: No, score=-107.911 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id K88koeE3ZPTh for ; Wed, 10 Jan 2018 15:31:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 81E505F620 for ; Wed, 10 Jan 2018 15:31:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id EB784E25BD for ; Wed, 10 Jan 2018 15:31:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 67830274DB for ; Wed, 10 Jan 2018 15:31:00 +0000 (UTC) Date: Wed, 10 Jan 2018 15:31:00 +0000 (UTC) From: "Johan Stenberg (JIRA)" To: issues@activemq.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (ARTEMIS-1596) Anonymous STOMP consumer/producer auto-creates address with wrong routing-type MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ARTEMIS-1596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16320437#comment-16320437 ] Johan Stenberg edited comment on ARTEMIS-1596 at 1/10/18 3:30 PM: ------------------------------------------------------------------ Btw. [this|https://github.com/apache/activemq-artemis/blob/master/artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/StompConnection.java#L270] also looks a bit fishy. Either the "routingType != null" check is redundant or what actually meant was "routingType == null || routingType == RoutingType.MULTICAST" or something. Also in this if-branch only the address but not the queue would be auto-created. was (Author: johan1): Btw. [this|https://github.com/apache/activemq-artemis/blob/master/artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/StompConnection.java#L270] also looks a bit fishy. Either the "routingType != null" check is redundant or what actually meant was "routingType == null || routingType == RoutingType.MULTICAST" or something. Also in this if branch only the address but not the queue would be auto-created. > Anonymous STOMP consumer/producer auto-creates address with wrong routing-type > ------------------------------------------------------------------------------ > > Key: ARTEMIS-1596 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1596 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: STOMP > Affects Versions: 2.4.0 > Environment: Artemis 2.5.0-SNAPSHOT > Reporter: Johan Stenberg > Assignee: Justin Bertram > Attachments: ArtemisTest.java, pom.xml > > > The routing type defined in the address settings seems to be ignored. -- This message was sent by Atlassian JIRA (v6.4.14#64029)