From issues-return-24619-archive-asf-public=cust-asf.ponee.io@activemq.apache.org Wed Jan 17 20:34:06 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 7F01D18062C for ; Wed, 17 Jan 2018 20:34:06 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 6D8F8160C47; Wed, 17 Jan 2018 19:34:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B4DCA160C25 for ; Wed, 17 Jan 2018 20:34:05 +0100 (CET) Received: (qmail 50324 invoked by uid 500); 17 Jan 2018 19:34:04 -0000 Mailing-List: contact issues-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list issues@activemq.apache.org Received: (qmail 50294 invoked by uid 99); 17 Jan 2018 19:34:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 17 Jan 2018 19:34:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 27EBD1A4304 for ; Wed, 17 Jan 2018 19:34:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.911 X-Spam-Level: X-Spam-Status: No, score=-99.911 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id cQg9R2FPHLmh for ; Wed, 17 Jan 2018 19:34:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 152415F340 for ; Wed, 17 Jan 2018 19:34:03 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 3CC7CE25DC for ; Wed, 17 Jan 2018 19:34:02 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 745B52130B for ; Wed, 17 Jan 2018 19:34:01 +0000 (UTC) Date: Wed, 17 Jan 2018 19:34:01 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@activemq.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ARTEMIS-1589) ActiveMQProtonRemotingConnection#getClientID does not return remote client ID MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ARTEMIS-1589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16329278#comment-16329278 ] ASF GitHub Bot commented on ARTEMIS-1589: ----------------------------------------- Github user jostbg commented on the issue: https://github.com/apache/activemq-artemis/pull/1773 @jbertram Could you please check if my [observations](https://issues.apache.org/jira/browse/ARTEMIS-1589) and my trivial fix are correct. Thanks in advance! > ActiveMQProtonRemotingConnection#getClientID does not return remote client ID > ----------------------------------------------------------------------------- > > Key: ARTEMIS-1589 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1589 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP > Affects Versions: 2.4.0 > Environment: Artemis 2.5.0-SNAPSHOT > Reporter: Johan Stenberg > Priority: Minor > > ActiveMQProtonRemotingConnection#getClientID currently returns the local container's clientID and not the actual (remote) client ID. Which it should from my interpretation of the JavaDoc at [RemotingConnection.java#L234|https://github.com/apache/activemq-artemis/blob/master/artemis-core-client/src/main/java/org/apache/activemq/artemis/spi/core/protocol/RemotingConnection.java#L234] > [StompConnection#getClientID|https://github.com/apache/activemq-artemis/blob/master/artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/StompConnection.java#L426] also returns the actual remote client ID. -- This message was sent by Atlassian JIRA (v7.6.3#76005)