From issues-return-25169-archive-asf-public=cust-asf.ponee.io@activemq.apache.org Fri Jan 26 16:56:04 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 9F5BC180657 for ; Fri, 26 Jan 2018 16:56:04 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 8F342160C3E; Fri, 26 Jan 2018 15:56:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D674E160C20 for ; Fri, 26 Jan 2018 16:56:03 +0100 (CET) Received: (qmail 89496 invoked by uid 500); 26 Jan 2018 15:56:03 -0000 Mailing-List: contact issues-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list issues@activemq.apache.org Received: (qmail 89487 invoked by uid 99); 26 Jan 2018 15:56:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 26 Jan 2018 15:56:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 779811A1461 for ; Fri, 26 Jan 2018 15:56:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -102.311 X-Spam-Level: X-Spam-Status: No, score=-102.311 tagged_above=-999 required=6.31 tests=[RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id zPAzwtKbv2xJ for ; Fri, 26 Jan 2018 15:56:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 425E15FAF6 for ; Fri, 26 Jan 2018 15:56:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 809BEE0161 for ; Fri, 26 Jan 2018 15:56:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3C2BC240EA for ; Fri, 26 Jan 2018 15:56:00 +0000 (UTC) Date: Fri, 26 Jan 2018 15:56:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@activemq.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ARTEMIS-550) Add support for virtual topic consumers MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ARTEMIS-550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16341187#comment-16341187 ] ASF GitHub Bot commented on ARTEMIS-550: ---------------------------------------- Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1820#discussion_r164147250 --- Diff: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQSession.java --- @@ -698,8 +699,17 @@ private ActiveMQMessageConsumer createConsumer(final ActiveMQDestination dest, */ if (!response.isExists() || !response.getQueueNames().contains(dest.getSimpleAddress())) { if (response.isAutoCreateQueues()) { + SimpleString queueNameToUse = dest.getSimpleAddress(); + SimpleString addressToUse = queueNameToUse; + RoutingType routingTypeToUse = RoutingType.ANYCAST; + if (CompositeAddress.isFullyQualified(queueNameToUse.toString())) { + CompositeAddress compositeAddress = CompositeAddress.getQueueName(queueNameToUse.toString()); + addressToUse = new SimpleString(compositeAddress.getAddress()); + queueNameToUse = new SimpleString(compositeAddress.getQueueName()); + routingTypeToUse = RoutingType.MULTICAST; --- End diff -- If this is a JMS Queue (des.isQueue), it should only be an ANYCAST > Add support for virtual topic consumers > --------------------------------------- > > Key: ARTEMIS-550 > URL: https://issues.apache.org/jira/browse/ARTEMIS-550 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker > Affects Versions: 1.3.0 > Reporter: Benjamin Graf > Assignee: Martyn Taylor > Priority: Major > Attachments: image-2018-01-26-09-02-08-192.png > > > Artemis should support virtual topic consumers as alternative to topic subscriptions as ActiveMQ itself does. -- This message was sent by Atlassian JIRA (v7.6.3#76005)