activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARTEMIS-1633) ActiveMQServerPlugin message routing callbacks should fire for all results
Date Thu, 25 Jan 2018 18:17:00 GMT

    [ https://issues.apache.org/jira/browse/ARTEMIS-1633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16339585#comment-16339585
] 

ASF GitHub Bot commented on ARTEMIS-1633:
-----------------------------------------

Github user cshannon commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1816#discussion_r163924828
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java
---
    @@ -772,6 +772,8 @@ public RoutingStatus route(final Message message,
     
           message.cleanupInternalProperties();
     
    +      server.callBrokerPlugins(server.hasBrokerPlugins() ? plugin -> plugin.beforeMessageRoute(message,
context, direct, rejectDuplicates) : null);
    --- End diff --
    
    If there were messages sent to an address with no bindings the message would get dropped
because of lack of bindings.  But with the old way the message route methods were only triggered
if the routing status was OK.  With the change the methods are called even if there are no
bindings but the status will say NO_BINDINGS, etc.


> ActiveMQServerPlugin message routing callbacks should fire for all results
> --------------------------------------------------------------------------
>
>                 Key: ARTEMIS-1633
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1633
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 2.4.0
>            Reporter: Christopher L. Shannon
>            Assignee: Christopher L. Shannon
>            Priority: Major
>             Fix For: 2.5.0
>
>
> When I added the callbacks for beforeMessageRoute and afterMessageRoute I accidentally
inserted them so that they will only be called when the RoutingStatus result is OK.  They
should always be called even if the status is no bindings, or no bindings DLA, etc to allow
the plugin writer to handle events depending on the routing status.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message