activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARTEMIS-1626) Disable thread leak check for failing tests
Date Mon, 22 Jan 2018 16:45:00 GMT

    [ https://issues.apache.org/jira/browse/ARTEMIS-1626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16334528#comment-16334528
] 

ASF GitHub Bot commented on ARTEMIS-1626:
-----------------------------------------

Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1800
  
    > @clebertsuconic I'm not convinced that it is that important to log a leakage on a
failed test. If a test
    > fails it should be fixed. With this PR you won't miss a real leakage.
    
    What.. you don't even want to log a leakage? that's information we need to determine if
subsequent tests may fail.
    
    A test shouldn't leak threads.. even if it failed.


> Disable thread leak check for failing tests
> -------------------------------------------
>
>                 Key: ARTEMIS-1626
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1626
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>          Components: Broker
>    Affects Versions: 2.4.0
>            Reporter: Howard Gao
>            Assignee: Howard Gao
>            Priority: Major
>             Fix For: 2.5.0
>
>
> The ThreadLeakCheckRule is used to check thread leaks
> after each test is finished. However when a test fails, it is
> not necessary to check leaking threads because the test
> failure should be fixed anyway. And leaking threads in a
> failed test may well be a result of the failure (once the test
> is fixed the thread leak may be gone).
> If a failed test also leaks threads, it takes a long time before
> the thread leak check finishes (60 seconds checking time),
> thus it takes a long time to finish, especially when tests are
> run in batches with failures.
> So to improve this, it should be reasonable to just enable
> the thread leaking check for each test passes, and disable
> the check when a test fails.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message